Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump minSdk to 21 / Drop support for KitKat and below #362

Closed
TacoTheDank opened this issue Jul 17, 2022 · 2 comments · Fixed by #364
Closed

Bump minSdk to 21 / Drop support for KitKat and below #362

TacoTheDank opened this issue Jul 17, 2022 · 2 comments · Fixed by #364

Comments

@TacoTheDank
Copy link
Contributor

These outdated versions are insecure, and the 3.x line of OkHttp is no longer maintained. See this.

If this is too large of a jump, it can be done first with a minSdk bump to 19.

I'm willing to work on this if you agree with the proposition.
@samfundev
Copy link
Collaborator

OkHttp dropping support for KitKat is a pretty big deal. Plus, I don't think I am able to keep up with fixing up bugs on old versions. I think it's probably best to move on and drop support for KitKat. I appreciate any help that you would be able to provide, especially since there was many things that were cleaned up in NewPipe that I would have missed.

@TacoTheDank
Copy link
Contributor Author

Sure thing 👍

@TacoTheDank TacoTheDank mentioned this issue Jul 19, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Bump minSdk to 21, cleanup TacoTheDank/Twire
2 participants
@samfundev @TacoTheDank