Drop support for Python 2.7 #328
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
twm
requested changes
Mar 25, 2020
Codecov Report
@@ Coverage Diff @@
## master #328 +/- ##
==========================================
- Coverage 98.16% 97.87% -0.29%
==========================================
Files 48 48
Lines 3928 3915 -13
Branches 262 259 -3
==========================================
- Hits 3856 3832 -24
- Misses 55 62 +7
- Partials 17 21 +4
Continue to review full report at Codecov.
|
twm
approved these changes
Mar 28, 2020
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
Blocked on #329 (Release Klein 20.4) |
wsanchez
changed the title
wsanchez
changed the title
* master: (26 commits) [requires.io] dependency update Fix #349: Update forms example to run correctly [requires.io] dependency update [requires.io] dependency update [requires.io] dependency update Don't use "l" as a variable name. [requires.io] dependency update [requires.io] dependency update [requires.io] dependency update [requires.io] dependency update [requires.io] dependency update [requires.io] dependency update [requires.io] dependency update [requires.io] dependency update [requires.io] dependency update [requires.io] dependency update mock 4 dropped Py2 hypothesis5 drops Py2 Update dependencies Don't have two tw192's ... # Conflicts: # .travis.yml # tox.ini
|
In case anyone noticed |
* master: [requires.io] dependency update [requires.io] dependency update
archlinux-github
pushed a commit
to archlinux/svntogit-community
that referenced
this pull request
Jun 20, 2021
Most of patches are home-grown instead of from upstream, as upstream fixes are quite large and cannot be cleanly backported. Specifically, upstream moves test strategies from Klein to Hyperlink [1] and drop Python 2.x support [2,3]. The fix for Werkzeug 2.x in test_resource.py [3] is smaller, while it cannot be cleanly backported, either. [1] twisted/klein#393 [2] twisted/klein#328 [3] twisted/klein#355 [4] twisted/klein#499 git-svn-id: file:///srv/repos/svn-community/svn@965883 9fca08f4-af9d-4005-b8df-a31f2cc04f65
archlinux-github
pushed a commit
to archlinux/svntogit-community
that referenced
this pull request
Jun 20, 2021
Most of patches are home-grown instead of from upstream, as upstream fixes are quite large and cannot be cleanly backported. Specifically, upstream moves test strategies from Klein to Hyperlink [1] and drop Python 2.x support [2,3]. The fix for Werkzeug 2.x in test_resource.py [3] is smaller, while it cannot be cleanly backported, either. [1] twisted/klein#393 [2] twisted/klein#328 [3] twisted/klein#355 [4] twisted/klein#499 git-svn-id: file:///srv/repos/svn-community/svn@965883 9fca08f4-af9d-4005-b8df-a31f2cc04f65
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current plan (as of Jan 25 2020) is that the final release of Python will be 2.7.18 slated for mid-April 2020.
This PR removes support for Python 2.7 from CI, removes Python 2.7-specific code, and reformats for Python 3.5+ per
black.Before we merge this, we should ship a release so that 2.7 users have the latest work already done with 2.7 support in place.