Upgrade Werkzeug to 2.x and fix affected tests #499
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* A redundant space before the word "If" is remove in Werkzeug 2.0 pallets/werkzeug@5fd1386#diff-b9d6906a0da8b5a9877b17ac5ea491161a660ce7e513921738d3e284bd9e9c96L528 * A `cast()` is no longer needed as Werkzeug 2.x is properly type-annotated: pallets/werkzeug@967b2da
Codecov Report
@@ Coverage Diff @@
## master #499 +/- ##
=======================================
Coverage 98.70% 98.70%
=======================================
Files 44 44
Lines 3849 3849
Branches 249 249
=======================================
Hits 3799 3799
Misses 33 33
Partials 17 17
Continue to review full report at Codecov.
|
wsanchez
approved these changes
Jun 7, 2021
|
@yan12125 Thanks for the patch. Much appreciated. |
archlinux-github
pushed a commit
to archlinux/svntogit-community
that referenced
this pull request
Jun 20, 2021
Most of patches are home-grown instead of from upstream, as upstream fixes are quite large and cannot be cleanly backported. Specifically, upstream moves test strategies from Klein to Hyperlink [1] and drop Python 2.x support [2,3]. The fix for Werkzeug 2.x in test_resource.py [3] is smaller, while it cannot be cleanly backported, either. [1] twisted/klein#393 [2] twisted/klein#328 [3] twisted/klein#355 [4] twisted/klein#499 git-svn-id: file:///srv/repos/svn-community/svn@965883 9fca08f4-af9d-4005-b8df-a31f2cc04f65
archlinux-github
pushed a commit
to archlinux/svntogit-community
that referenced
this pull request
Jun 20, 2021
Most of patches are home-grown instead of from upstream, as upstream fixes are quite large and cannot be cleanly backported. Specifically, upstream moves test strategies from Klein to Hyperlink [1] and drop Python 2.x support [2,3]. The fix for Werkzeug 2.x in test_resource.py [3] is smaller, while it cannot be cleanly backported, either. [1] twisted/klein#393 [2] twisted/klein#328 [3] twisted/klein#355 [4] twisted/klein#499 git-svn-id: file:///srv/repos/svn-community/svn@965883 9fca08f4-af9d-4005-b8df-a31f2cc04f65
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A redundant space before the word "If" is remove in Werkzeug 2.0
pallets/werkzeug@5fd1386#diff-b9d6906a0da8b5a9877b17ac5ea491161a660ce7e513921738d3e284bd9e9c96L528
A
cast()is no longer needed as Werkzeug 2.x is properlytype-annotated: pallets/werkzeug@967b2da
I noticed this when I was testing klein with the latest Python packages. Someone Werkzeug is not automatically upgraded via requires.io, and several others (e.g., attrs, six) are already out-dated before the last requires.io pull request (#498), too. I guess something was wrong at their end.