examples: stream downloaded file without buffering #233
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to this change, treq would buffer the entire file in memory, and Python's memory usage would rise to match the entire file size.
|
inspired by the discussion in #116 |
Codecov Report
@@ Coverage Diff @@
## master #233 +/- ##
=======================================
Coverage 98.86% 98.86%
=======================================
Files 26 26
Lines 2285 2285
Branches 165 165
=======================================
Hits 2259 2259
Misses 14 14
Partials 12 12Continue to review full report at Codecov.
|
twm
approved these changes
Feb 7, 2019
| @@ -5,7 +5,7 @@ | |||
|
|
|||
| def download_file(reactor, url, destination_filename): | |||
| destination = open(destination_filename, 'wb') | |||
| d = treq.get(url) | |||
| d = treq.get(url, unbuffered=True) | |||
There was a problem hiding this comment.
Strange, I made this change myself some time ago. It must have gotten clobbered in a merge.
twm
added a commit
to twm/treq
that referenced
this pull request
Mar 15, 2020
bmwiedemann
referenced
this pull request
in bmwiedemann/openSUSE
Mar 25, 2020
https://build.opensuse.org/request/show/788271 by user scarabeus_iv + dimstar_suse - version update to 20.3.0 - Python 3.7 support. (`#228 <https://github.com/twisted/treq/issues/228>`__) - `treq.testing.RequestTraversalAgent` now passes its memory reactor to the `twisted.web.server.Site` it creates, preventing the ``Site`` from polluting the global reactor. (`#225 <https://github.com/twisted/treq/issues/225>`__) - `treq.testing` no longer generates deprecation warnings about ``twisted.test.proto_helpers.MemoryReactor``. (`#253 <https://github.com/twisted/treq/issues/253>`__) - The ``download_file.py`` example has been updated to do a streaming download with *unbuffered=True*. (`#233 <https://github.com/twisted/treq/issues/233>`__) - The *agent* parameter to `treq.request()` has been documented. (`#235 <https://github.com/twisted/treq/issues/235>`__) - The typ
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this change, treq would buffer the entire file in memory, and Python's memory usage would rise to match the entire file size.