We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
If a header value is something other than a string, bytes, or list, treq will silently drop the header. It should raise an error instead.
For example this request would not send Some-Header:
Some-Header
treq.get('http://example.com', headers={'Some-Header': uuid.uuid4()})
This if statement needs a final else to raise an error.
else
treq/src/treq/client.py
Lines 171 to 175 in 7a8f45a
The text was updated successfully, but these errors were encountered:
This will no longer be silent in the next release, as treq will issue a deprecation warning. The release after that, #302 calls for a TypeError.
TypeError
Sorry, something went wrong.
twm
Successfully merging a pull request may close this issue.
If a header value is something other than a string, bytes, or list, treq will silently drop the header. It should raise an error instead.
For example this request would not send
Some-Header
:This if statement needs a final
else
to raise an error.treq/src/treq/client.py
Lines 171 to 175 in 7a8f45a
The text was updated successfully, but these errors were encountered: