Improve error message for short/long file tuples #299
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If passed a tuple with a length other than 2 or 3 IBodyProducer would
end up trying to adapt None, producing this confusing message:
Traceback (most recent call last):
File ".../treq/test/test_client.py", line 513, in test_request_files_bad_tuples
self.client.request(
File ".../treq/client.py", line 190, in request
bodyProducer, contentType = self._request_body(
File ".../treq/client.py", line 297, in _request_body
files = list(_convert_files(files))
File ".../treq/client.py", line 388, in _convert_files
yield (param, (file_name, content_type, IBodyProducer(fobj)))
builtins.TypeError: ('Could not adapt', None, <InterfaceClass twisted.web.iweb.IBodyProducer>)
This changeset produces a TypeError that mentions tuple length.
adiroiban
approved these changes
Dec 28, 2020
Co-authored-by: Adi Roiban <adiroiban@gmail.com>
|
Thank you for the review @adiroiban! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If passed a tuple with a length other than 2 or 3
IBodyProducerwould end up trying to adaptNone, producing this confusing message:This changeset produces a
TypeErrorthat mentions tuple length.