-
Notifications
You must be signed in to change notification settings - Fork 102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dropping support python <= 2.5, small tidy-ups, expanding test coverage #103
Conversation
Coverage for GridFS, cool! |
1 similar comment
There should be more coverage than that... I didn't write those tests for nothing. I'll need to investigate more. :/ |
Btw, did you know about |
fix missing os.SEEK_END, use undocumented version since with tests only work with twisted >= 15 more coverage dicts are unordered removed unsupported APIs, as they are from the 1.5 time. no need to carry them forward adding .put .get coverage renamed test, now with better coverage, additional fixes added gridfs initialization to test
@IlyaSkriblovsky I haven't used
The html output it produces is quite nice to quickly look through the code and identify areas that need testing. |
@trenton42 +1 for my toolset, thanks. Didn't used either before. |
@IlyaSkriblovsky and thank you for all the work you've done on on increasing coverage! |
@IlyaSkriblovsky it is what I use, you can see it in our Makefile |
dropping support python <= 2.5, small tidy-ups, expanding test coverage
"which trial" makes me chuckle every time |
91% :) |
fix missing os.SEEK_END, use undocumented version since with tests only work with twisted >= 15
removed unsupported APIs, as they are from the 1.5 time. no need to carry them forward
adding GridFS .put .get coverage