Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dropping support python <= 2.5, small tidy-ups, expanding test coverage #103

Merged
merged 2 commits into from
May 26, 2015

Conversation

psi29a
Copy link
Contributor

@psi29a psi29a commented May 25, 2015

fix missing os.SEEK_END, use undocumented version since with tests only work with twisted >= 15
removed unsupported APIs, as they are from the 1.5 time. no need to carry them forward
adding GridFS .put .get coverage

@IlyaSkriblovsky
Copy link
Contributor

Coverage for GridFS, cool!

@coveralls
Copy link

Coverage Status

Coverage increased (+0.9%) to 86.17% when pulling 4b15dda on psi29a:gridfs_coverage into 80cc4c3 on twisted:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage increased (+0.9%) to 86.17% when pulling 4b15dda on psi29a:gridfs_coverage into 80cc4c3 on twisted:master.

@psi29a
Copy link
Contributor Author

psi29a commented May 26, 2015

There should be more coverage than that... I didn't write those tests for nothing. I'll need to investigate more. :/

@IlyaSkriblovsky
Copy link
Contributor

Btw, did you know about --coverage option for trial? I've opened it for myself recently and it helps a lot while writing tests.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.91%) to 87.75% when pulling ca799ab on psi29a:gridfs_coverage into 702f764 on twisted:master.

fix missing os.SEEK_END, use undocumented version since with tests only work with twisted >= 15

more coverage

dicts are unordered

removed unsupported APIs, as they are from the 1.5 time. no need to carry them forward

adding .put .get coverage

renamed test, now with better coverage, additional fixes

added gridfs initialization to test
@trenton42
Copy link
Contributor

@IlyaSkriblovsky I haven't used trial's --coverage option, is that better than using coverage.py? I usually run:

coverage run --source=txmongo `which trial` tests

The html output it produces is quite nice to quickly look through the code and identify areas that need testing.

@IlyaSkriblovsky
Copy link
Contributor

@trenton42 +1 for my toolset, thanks. Didn't used either before.

@trenton42
Copy link
Contributor

@IlyaSkriblovsky and thank you for all the work you've done on on increasing coverage!

@psi29a
Copy link
Contributor Author

psi29a commented May 26, 2015

@IlyaSkriblovsky it is what I use, you can see it in our Makefile

@coveralls
Copy link

Coverage Status

Coverage increased (+4.38%) to 90.91% when pulling 27f01ea on psi29a:gridfs_coverage into bd50ab9 on twisted:master.

psi29a added a commit that referenced this pull request May 26, 2015
dropping support python <= 2.5, small tidy-ups, expanding test coverage
@psi29a psi29a merged commit 779b2df into twisted:master May 26, 2015
@trenton42
Copy link
Contributor

"which trial" makes me chuckle every time

@psi29a
Copy link
Contributor Author

psi29a commented May 26, 2015

91% :)

@psi29a psi29a deleted the gridfs_coverage branch May 26, 2015 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants