-
Notifications
You must be signed in to change notification settings - Fork 104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Compatibility with PyMongo 3.7 #233
Compatibility with PyMongo 3.7 #233
Conversation
I've also noticed that some of our tests are failing with MongoDB 3.6. Will look into it too. |
1 similar comment
Should we start keeping documentation stating where we lifted code from PyMongo? I can imagine that in the future that something breaks that was 'fixed' in a later version of PyMongo. In comment:
What do you think? |
I think this is great idea. Going to add this, thanks. |
@psi29a I've added references to original PyMongo sources we have copied code from. I'm not sure how to specify "reason why we copied" because in all cases it will be "because we need to do the same thing PyMongo does and we don't want to be at risk when PyMongo will change its private functions". All that we have copied are some useful utility functions that deal with MongoDB responses and convert them to python objects or raise exceptions. |
That's good enough, that we know it's copied can give us a clue. |
If this looks good I think we should make a release because currently |
Fixing #232
Copy-pasted some internal pymongo utility methods into txmongo so future pymongo updates won't break txmongo.