Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compatibility with PyMongo 3.7 #233

Merged
merged 4 commits into from Jul 14, 2018

Conversation

IlyaSkriblovsky
Copy link
Contributor

Fixing #232

Copy-pasted some internal pymongo utility methods into txmongo so future pymongo updates won't break txmongo.

@IlyaSkriblovsky
Copy link
Contributor Author

I've also noticed that some of our tests are failing with MongoDB 3.6. Will look into it too.

@coveralls
Copy link

coveralls commented Jul 5, 2018

Coverage Status

Coverage decreased (-0.8%) to 94.373% when pulling ccdf224 on IlyaSkriblovsky:pymongo-3.7-compatibility into 2074262 on twisted:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.9%) to 94.268% when pulling cf323c9 on IlyaSkriblovsky:pymongo-3.7-compatibility into 2074262 on twisted:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.9%) to 94.268% when pulling cf323c9 on IlyaSkriblovsky:pymongo-3.7-compatibility into 2074262 on twisted:master.

@psi29a
Copy link
Contributor

psi29a commented Jul 6, 2018

Should we start keeping documentation stating where we lifted code from PyMongo? I can imagine that in the future that something breaks that was 'fixed' in a later version of PyMongo.

In comment:

  • reason why we copied with link to issue
  • which pymongo version, maybe even link to the tagged released file/line

What do you think?

@IlyaSkriblovsky
Copy link
Contributor Author

I think this is great idea. Going to add this, thanks.

@IlyaSkriblovsky
Copy link
Contributor Author

@psi29a I've added references to original PyMongo sources we have copied code from. I'm not sure how to specify "reason why we copied" because in all cases it will be "because we need to do the same thing PyMongo does and we don't want to be at risk when PyMongo will change its private functions". All that we have copied are some useful utility functions that deal with MongoDB responses and convert them to python objects or raise exceptions.

@psi29a
Copy link
Contributor

psi29a commented Jul 13, 2018

That's good enough, that we know it's copied can give us a clue.

@IlyaSkriblovsky
Copy link
Contributor Author

If this looks good I think we should make a release because currently pip install txmongo is installing non-working environment.

@psi29a psi29a merged commit 92284c3 into twisted:master Jul 14, 2018
@IlyaSkriblovsky IlyaSkriblovsky deleted the pymongo-3.7-compatibility branch July 19, 2018 07:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants