Tests fixed with MongoDB 3.6 #234
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
psi29a
reviewed
Jul 6, 2018
| @@ -68,7 +68,6 @@ def start(self): | |||
| b"--noprealloc", b"--nojournal", | |||
| b"--smallfiles", b"--nssize", b"1", | |||
| b"--oplogSize", b"1", | |||
| b"--nohttpinterface", | |||
There was a problem hiding this comment.
Thank you for this! I had to do this for an internal project too. :)
|
Can we merge this? |
|
Done and done. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing some test failures when running against MongoDB 3.6. TxMongo works fine with 3.6, this issue only affects testing code that hardcodes some error message texts and other internal MongoDB stuff from 3.4. No user-visible changes here.
This PR is based on #233 and includes its commits, so it should be merged only after that.