Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Marshal interfaces #261

Closed
cannon73 opened this issue Aug 12, 2020 · 2 comments
Closed

Use Marshal interfaces #261

cannon73 opened this issue Aug 12, 2020 · 2 comments

Comments

@cannon73
Copy link

I have some doubts about the T.W.I.R.P. software. It calls the proto buf package functions proto.Marshal and proto.Unmarshal to serialize the data. Is that the right object oriented go way to do this? Would it not be better to use an interface so that other serialization packages could be used? Kindly include my solution to support the Marshal and Unmarshal interfaces.

marshal.zip

@marioizquierdo
Copy link
Contributor

@cannon73 could you explain with more details? please include examples in the comment, it is not easy to know what you mean from the zip file

@marioizquierdo
Copy link
Contributor

I think you are talking about Protobuf. The new version of the proto package implements the Marshal interface as you would expect, but Twirp is still using the older version of it. There's another issue already mentioning this issue: #222

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants