Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider to add more information in TwitterResponse #637

Closed
myConsciousness opened this issue Jan 23, 2023 · 0 comments · Fixed by #638
Closed

Consider to add more information in TwitterResponse #637

myConsciousness opened this issue Jan 23, 2023 · 0 comments · Fixed by #638
Assignees
@myConsciousness
Labels
enhancement New feature or request

Comments

@myConsciousness
Copy link
Owner

1. Problem to solve

  • statusCode or status
  • headers (as object...?)

2. Proposal

3. More information
@myConsciousness myConsciousness added the enhancement New feature or request label Jan 23, 2023
@myConsciousness myConsciousness self-assigned this Jan 23, 2023
@myConsciousness myConsciousness linked a pull request Jan 24, 2023 that will close this issue
feat: fixed for the issue (#637) #638
Merged
7 tasks
bors bot added a commit that referenced this issue Jan 24, 2023
@bors @myConsciousness
Merge #638
6abe0a3 
638: feat: fixed for the issue (#637) r=myConsciousness a=myConsciousness

# 1. Description

<!-- Provide a description of what this PR is doing.
If you're modifying existing behavior, describe the existing behavior, how this PR is changing it,
and what motivated the change. If this is a breaking change, specify explicitly which APIs have been
changed. -->

## 1.1. Checklist

<!-- Before you create this PR confirm that it meets all requirements listed below by checking the
relevant checkboxes (`[x]`). This will ensure a smooth and quick review process. -->

- [x] The title of my PR starts with a [Conventional Commit] prefix (`fix:`, `feat:`, `docs:` etc).
- [x] I have read the [Contributor Guide] and followed the process outlined for submitting PRs.
- [x] I have updated/added tests for ALL new/updated/fixed functionality.
- [x] I have updated/added relevant documentation in `docs` and added dartdoc comments with `///`.
- [x] I have updated/added relevant examples in `examples`.

## 1.2. Breaking Change

<!-- Does your PR require users to manually update their apps to accommodate your change?

If the PR is a breaking change this should be indicated with suffix "!"  (for example, `feat!:`, `fix!:`). See [Conventional Commit] for details.
-->

- [ ] Yes, this is a breaking change.
- [x] No, this is _not_ a breaking change.

## 1.3. Related Issues

<!-- Provide a list of issues related to this PR from the [issue database].
Indicate which of these issues are resolved or fixed by this PR, i.e. Fixes #xxxx* !-->

<!-- Links -->

[issue database]: https://github.com/twitter-dart/twitter-api-v2/issues
[contributor guide]: https://github.com/twitter-dart/twitter-api-v2/blob/main/CONTRIBUTING.md
[style guide]: https://github.com/twitter-dart/twitter-api-v2/blob/main/STYLEGUIDE.md
[conventional commit]: https://conventionalcommits.org


Co-authored-by: myConsciousness <contact@shinyakato.dev>
@bors bors bot closed this as completed in #638 Jan 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@myConsciousness myConsciousness

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: fixed for the issue (#637) myConsciousness/twitter-api-v2
1 participant
@myConsciousness