Skip to content
This repository has been archived by the owner on Nov 1, 2021. It is now read-only.

fix SPDY headers so dependent projects can stop using pch files #96

Merged
merged 1 commit into from
Jan 6, 2015

Conversation

johnkdoe
Copy link

@johnkdoe johnkdoe commented Jan 6, 2015

when attempting to build our project that depends upon
CocoaSPDY without precompiled headers, we found a
couple of errors:

  • SPDYError.h refers to NSString
    • solution: import Foundation.h
  • SPDYError.h has externs that could be in C, C++ or Objective-C code
    • solution: use FOUNDATION_IMPORT, found in Foundation.h
  • SPDYLogger.h refers to NSString
    • solution: import Foundation.h

Change-Id: I0828b29ab4a00b533a19e8e3aaa70f094b93bfde
@coveralls
Copy link

Coverage Status

Coverage remained the same when pulling daf4d98 on johnkdoe:import-cleanup into 4bd59a8 on twitter:develop.

goaway added a commit that referenced this pull request Jan 6, 2015
fix SPDY headers so dependent projects can stop using pch files
@goaway goaway merged commit 87c3d38 into twitter-archive:develop Jan 6, 2015
@goaway
Copy link
Collaborator

goaway commented Jan 6, 2015

Thanks!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants