Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a Bloom Filter from an iterator #637

Merged
merged 1 commit into from
Jul 26, 2017

Conversation

johandahlberg
Copy link
Contributor

This PR simply adds the option of creating a Bloom Filter directly from an iterator. I found this useful in my own code, so perhaps someone else will also find it useful.

@codecov-io
Copy link

Codecov Report

Merging #637 into develop will increase coverage by 0.04%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #637      +/-   ##
===========================================
+ Coverage    82.09%   82.14%   +0.04%     
===========================================
  Files          111      111              
  Lines         5156     5157       +1     
  Branches       457      468      +11     
===========================================
+ Hits          4233     4236       +3     
+ Misses         923      921       -2
Impacted Files Coverage Δ
.../main/scala/com/twitter/algebird/BloomFilter.scala 94.34% <100%> (+0.89%) ⬆️
.../main/scala/com/twitter/algebird/Applicative.scala 61.29% <0%> (-3.23%) ⬇️
...c/main/scala/com/twitter/algebird/MapAlgebra.scala 76.69% <0%> (-0.98%) ⬇️
...src/main/scala/com/twitter/algebird/Interval.scala 69.04% <0%> (ø) ⬆️
.../main/scala/com/twitter/algebird/Approximate.scala 90.32% <0%> (+1.61%) ⬆️
.../main/scala/com/twitter/algebird/Successible.scala 91.66% <0%> (+4.16%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 43cacc4...976386a. Read the comment docs.

@sritchie
Copy link
Collaborator

looks great!

@sritchie sritchie merged commit 1f62f5b into twitter:develop Jul 26, 2017
@sritchie
Copy link
Collaborator

Thanks for this, @johandahlberg, and thanks for the test!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants