Add a module for finagle bijections. #197

folone · 2015-02-20T13:47:05Z

As suggested in twitter/finagle#341, implemented Bijections and Injections for finagle-mysql datatypes.

> bijection-finagle/console
[info] Starting scala interpreter...
[info]
Welcome to Scala version 2.10.4 (Java HotSpot(TM) 64-Bit Server VM, Java 1.8.0_20).
Type in expressions to have them evaluated.
Type :help for more information.

scala> import com.twitter.finagle.exp.mysql._
import com.twitter.finagle.exp.mysql._

scala> import com.twitter.bijection.Conversion.asMethod
import com.twitter.bijection.Conversion.asMethod

scala> import com.twitter.bijection.twitter_finagle.MySqlConversions._
import com.twitter.bijection.twitter_finagle.MySqlConversions._

scala> NullValue.as[Option[String]]
res1: Option[String] = None

scala> StringValue("Hej").as[String]
res2: String = Hej

scala> IntValue(10).as[Option[Int]]
res3: Option[Int] = Some(10)

mosesn · 2015-02-20T15:47:54Z

@johnynek @folone is this the right place to put this? I was thinking that it would be OK to just make finagle-mysql take a dependency on bijections, but I don't have really strong opinions about this. Although it might make more sense to make this a bijection-finagle-mysql lib than bijection-finagle.

ianoc · 2015-02-20T17:08:25Z

bijection-finagle/src/main/scala/com/twitter/bijection/twitter_finagle/MySqlConversions.scala

+limitations under the License.
+*/
+
+package com.twitter.bijection.twitter_finagle


twitter_finagle? are there other finagle projects? should drop the twitter_

+1, also note the com.twitter prefix.

johnynek · 2015-02-20T19:49:04Z

This looks great, aside from a few minor suggestions. Thanks so much for doing this!

folone · 2015-02-22T14:06:18Z

Addressed the review in 55b7e8b.

mosesn · 2015-02-22T15:58:49Z

LGTM

johnynek · 2015-02-23T19:05:09Z

...tion-finagle-mysql/src/main/scala/com/twitter/bijection/finagle_mysql/MySqlConversions.scala

+      private val UTC = java.util.TimeZone.getTimeZone("UTC")
+      private val timestampValue = new TimestampValue(UTC, UTC)
+      def apply(t: Timestamp) = timestampValue(t)
+      override def invert(v: Value) = Inversion.attempt(timestampValue.unapply(v).get)(identity)


this is not how attempt works. Yours will throw if the inversion fails. It should be:

Inversion.attempt(v) { v => timestampValue.unapply(v).get }

Oh! Thanks, fixed!

johnynek · 2015-02-23T19:05:29Z

one minor issue.

johnynek · 2015-02-23T19:40:31Z

Thanks!

Add a module for finagle bijections.

folone · 2015-02-23T19:41:55Z

folone · 2015-02-23T19:42:04Z

Thanks!

MansurAshraf · 2015-02-23T20:21:47Z

@folone your tests are failing. Instead of extending PropertyChecks can you extend CheckProperties from #198 and rerun your tests?

[info] Compiling 1 Scala source to bijection/bijection-finagle-mysql/target/scala-2.10/test-classes...
[info] MySqlConversionLaws:
[info] - Byte
[info] - Short
[info] - Int
[info] - Long
[info] - Float
[info] - Double
[info] - String
[info] - Boolean *** FAILED ***
[info]   GeneratorDrivenPropertyCheckFailedException was thrown during property evaluation.
[info]    (CheckProperties.scala:12)
[info]     Falsified after 0 successful property evaluations.
[info]     Location: (CheckProperties.scala:12)
[info]     Occurred when passed generated values (
[info]       arg0 = ByteValue(127)
[info]     )
[info] - Timestamp *** FAILED ***
[info]   GeneratorDrivenPropertyCheckFailedException was thrown during property evaluation.
[info]    (CheckProperties.scala:12)
[info]     Falsified after 0 successful property evaluations.
[info]     Location: (CheckProperties.scala:12)
[info]     Occurred when passed generated values (
[info]       arg0 = 24501659-11-03 14:26:24.675
[info]     )
[info] - Empty *** FAILED ***
[info]   GeneratorDrivenPropertyCheckFailedException was thrown during property evaluation.
[info]    (CheckProperties.scala:12)
[info]     Falsified after 0 successful property evaluations.
[info]     Location: (CheckProperties.scala:12)
[info]     Occurred when passed generated values (
[info]       arg0 = EmptyValue
[info]     )
[info] - Null *** FAILED ***
[info]   GeneratorDrivenPropertyCheckFailedException was thrown during property evaluation.
[info]    (CheckProperties.scala:12)
[info]     Falsified after 0 successful property evaluations.
[info]     Location: (CheckProperties.scala:12)
[info]     Occurred when passed generated values (
[info]       arg0 = NullValue
[info]     )
[info] ScalaTest
[info] Run completed in 635 milliseconds.
[info] Total number of tests run: 11
[info] Suites: completed 1, aborted 0
[info] Tests: succeeded 7, failed 4, canceled 0, ignored 0, pending 0
[info] *** 4 TESTS FAILED ***

folone · 2015-02-23T20:26:09Z

@MansurAshraf I believe @johnynek already merged this PR though. Should I send another one against your branch?

MansurAshraf · 2015-02-23T20:28:10Z

@folone yes thats fine. Thank you!

folone · 2015-02-24T07:27:36Z

@MansurAshraf I just tried extending CheckProperties, same errors. Here's the diff:

Compiling garden.css...
diff --git a/bijection-finagle-mysql/src/test/scala/com/twitter/bijection/finagle_mysql/MySqlConversionLaws.scala b/bijection-finagle-mysql/src/test/scala/com/twitter/bijection/finagle_mysql/MySqlConversionLaws.scala
index 7328abd..ffc64f7 100644
--- a/bijection-finagle-mysql/src/test/scala/com/twitter/bijection/finagle_mysql/MySqlConversionLaws.scala
+++ b/bijection-finagle-mysql/src/test/scala/com/twitter/bijection/finagle_mysql/MySqlConversionLaws.scala
@@ -18,8 +18,6 @@ package com.twitter.bijection.finagle_mysql

 import com.twitter.bijection.{ CheckProperties, BaseProperties, Bijection }
 import org.scalacheck.Arbitrary
-import org.scalatest.{ PropSpec, MustMatchers }
-import org.scalatest.prop.PropertyChecks
 import com.twitter.finagle.exp.mysql._
 import java.sql.Timestamp
 import java.util.Date
@@ -29,7 +27,7 @@ import org.scalacheck.Gen
 import org.scalacheck.Arbitrary
 import org.scalacheck.Arbitrary.arbitrary

-class MySqlConversionLaws extends PropSpec with PropertyChecks with MustMatchers with BaseProperties {
+class MySqlConversionLaws extends CheckProperties with BaseProperties {
   import MySqlConversions._

   implicit val byteValueArb = Arbitrary(arbitrary[Byte].map(ByteValue.apply))

MansurAshraf · 2015-02-24T16:06:07Z

@folone are these valid test failures? Do you think you can fix them otherwise we will have to revert the change. @johnynek what do you think?

folone · 2015-02-25T09:09:50Z

@MansurAshraf I'll have some time to look at it on Friday. I'm wondering how those tests were working before #198 though.

MansurAshraf · 2015-02-25T18:28:14Z

@folone they were not running. See twitter/algebird#421 (its for algebird but same issue was happening in this project)

johnynek · 2015-02-25T20:42:15Z

@MansurAshraf is right. I missed that in the review. We had a bug in some our tests after the migration to scalatest, and your code copied that pattern.

folone · 2015-02-26T16:59:01Z

Here's the fix: #201

Add a module for finagle bijections.

e5da332

folone mentioned this pull request Feb 20, 2015

[WIP] Typeclass-based value extraction for finagle-mysql datatypes. twitter/finagle#341

Closed

ianoc reviewed Feb 20, 2015
View reviewed changes

johnynek reviewed Feb 23, 2015
View reviewed changes

johnynek mentioned this pull request Feb 23, 2015

Make property tests work again #198

Merged

Address the review.

547585a

folone force-pushed the finagle-mysql branch from 55b7e8b to 547585a Compare February 23, 2015 19:25

johnynek added a commit that referenced this pull request Feb 23, 2015

Merge pull request #197 from folone/finagle-mysql

3162abc

Add a module for finagle bijections.

johnynek merged commit 3162abc into twitter:develop Feb 23, 2015

folone deleted the finagle-mysql branch February 23, 2015 19:42

MansurAshraf mentioned this pull request Feb 24, 2015

bijection-finagle-mysql tests are failing in develop #200

Open

folone mentioned this pull request Feb 26, 2015

Fix tests for finagle-mysql subproject. #201

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add a module for finagle bijections. #197

Add a module for finagle bijections. #197

folone commented Feb 20, 2015

mosesn commented Feb 20, 2015

ianoc Feb 20, 2015

johnynek Feb 20, 2015

johnynek commented Feb 20, 2015

folone commented Feb 22, 2015

mosesn commented Feb 22, 2015

johnynek Feb 23, 2015

folone Feb 23, 2015

johnynek commented Feb 23, 2015

johnynek commented Feb 23, 2015

folone commented Feb 23, 2015

folone commented Feb 23, 2015

MansurAshraf commented Feb 23, 2015

folone commented Feb 23, 2015

MansurAshraf commented Feb 23, 2015

folone commented Feb 24, 2015

MansurAshraf commented Feb 24, 2015

folone commented Feb 25, 2015

MansurAshraf commented Feb 25, 2015

johnynek commented Feb 25, 2015

folone commented Feb 26, 2015

Add a module for finagle bijections. #197

Add a module for finagle bijections. #197

Conversation

folone commented Feb 20, 2015

mosesn commented Feb 20, 2015

ianoc Feb 20, 2015

Choose a reason for hiding this comment

johnynek Feb 20, 2015

Choose a reason for hiding this comment

johnynek commented Feb 20, 2015

folone commented Feb 22, 2015

mosesn commented Feb 22, 2015

johnynek Feb 23, 2015

Choose a reason for hiding this comment

folone Feb 23, 2015

Choose a reason for hiding this comment

johnynek commented Feb 23, 2015

johnynek commented Feb 23, 2015

folone commented Feb 23, 2015

folone commented Feb 23, 2015

MansurAshraf commented Feb 23, 2015

folone commented Feb 23, 2015

MansurAshraf commented Feb 23, 2015

folone commented Feb 24, 2015

MansurAshraf commented Feb 24, 2015

folone commented Feb 25, 2015

MansurAshraf commented Feb 25, 2015

johnynek commented Feb 25, 2015

folone commented Feb 26, 2015