-
Notifications
You must be signed in to change notification settings - Fork 124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make property tests work again #198
Conversation
Looks good to me, but question: how can we be sure the tests are all running now? Can we set scalatest to error if you have a property that never asserts? |
I inverted the assert conditions in BaseProperties and made sure that tests run and fail. |
@MansurAshraf cool. Can you comment on what the PR in #197 should do to be compatible with this style? |
The URL injection test failed. It is flakey. Can you switch it from using the default Arbitrary.arbitrary[String].filter(s => Try(new Url(s)).isSuccess) then we only start with strings that won't throw. |
b109ee2
to
4cc105e
Compare
Thanks for doing this! Next stop: code coverage. |
Make property tests work again
Tests were not running before. This change ensure tests are running (but not necessarily passing ...yet)