Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make property tests work again #198

Merged
merged 8 commits into from
Feb 24, 2015

Conversation

MansurAshraf
Copy link
Contributor

Tests were not running before. This change ensure tests are running (but not necessarily passing ...yet)

@johnynek
Copy link
Collaborator

Looks good to me, but question: how can we be sure the tests are all running now? Can we set scalatest to error if you have a property that never asserts?

@MansurAshraf
Copy link
Contributor Author

I inverted the assert conditions in BaseProperties and made sure that tests run and fail.

@johnynek
Copy link
Collaborator

@MansurAshraf cool. Can you comment on what the PR in #197 should do to be compatible with this style?

@johnynek
Copy link
Collaborator

The URL injection test failed. It is flakey. Can you switch it from using the default Arbitrary.arbitrary[String]: Gen[String] to something like:

Arbitrary.arbitrary[String].filter(s => Try(new Url(s)).isSuccess)

then we only start with strings that won't throw.

@johnynek
Copy link
Collaborator

Thanks for doing this! Next stop: code coverage.

johnynek added a commit that referenced this pull request Feb 24, 2015
@johnynek johnynek merged commit 8b99525 into twitter:develop Feb 24, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants