Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor API: s/node/vertex #213

Open
lintool opened this issue May 24, 2016 · 3 comments
Open

Refactor API: s/node/vertex #213

lintool opened this issue May 24, 2016 · 3 comments

Comments

@lintool
Copy link

lintool commented May 24, 2016

We should rename Node to Vertex in the API. Two main reasons:

  1. Vertex makes you sound smarter... :)
  2. If we want to start playing with partitioning, we want to reserve "Node" for logical/physical machine nodes, so getNode and getVertex can be easily disambiguated.
@pankajgupta
Copy link
Contributor

Agreed.

@lintool
Copy link
Author

lintool commented Jun 2, 2016

Okay, I'll refactor and send a pull request... this will help me get my feet wet and learn the API, etc.

@pankajgupta
Copy link
Contributor

Looking forward :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@pankajgupta @lintool