Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistency in Node API #225

Open
lintool opened this issue Nov 16, 2016 · 1 comment
Open

Inconsistency in Node API #225

lintool opened this issue Nov 16, 2016 · 1 comment

Comments

@lintool
Copy link

lintool commented Nov 16, 2016

If we look at the Node API, we have:

def randomOutboundNodeSet(numResults: Int, rnd: Random): Seq[Int]:
https://github.com/twitter/cassovary/blob/master/cassovary-core/src/main/scala/com/twitter/cassovary/graph/Node.scala#L123

def outboundNodes(): CSeq[Int]:
https://github.com/twitter/cassovary/blob/master/cassovary-core/src/main/scala/com/twitter/cassovary/graph/Node.scala#L89

Note that one returns a CSeq and the other returns a Seq. Should this be made consistent?

@pankajgupta
Copy link
Contributor

Good catch. Will fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants