finagle-memcached: KetamaClientBuilder - expose the client type #280
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
lgtm |
|
LGTM Thanks for the contribution. |
stevegury
added a commit
that referenced
this pull request
Jun 25, 2014
…he build() API Problem KetamaClientBuilder.build() doesn't expose the exact client type. Solution Expose the client type `KetamaClient` in the build() API. from github: #280 Signed-off-by: Steve Gury <stevegury@twitter.com>- Problem RB_ID=384391
|
@fwbrasil it turns out that this is a binary incompatible change, and we won't be able to do it until we do a major version bump. Although we had merged it in, we had to revert it. |
suncelesta
pushed a commit
to suncelesta/finagle
that referenced
this pull request
Feb 19, 2015
…he build() API Problem KetamaClientBuilder.build() doesn't expose the exact client type. Solution Expose the client type `KetamaClient` in the build() API. from github: twitter#280 Signed-off-by: Steve Gury <stevegury@twitter.com>- Problem RB_ID=384391
|
@fwbrasil we've stopped following semver so religiously, so I think we'd be happy to merge this in. you think it's still worth doing? |
|
@mosesn I'd prefer to close it, I'm not sure if it'd be useful anymore. |
|
Works for me. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to access the client nodes for operations like individual node stats.