finagle-core: make ApertureLoadBandBalancer public #370
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Problem I want to use the Aperture LoadBalancerFactory with custom values. The class is private, so we are unable to create a new object that instantiates the ApertureLoadBandBalancer class. I also want to experiment with creating load balancers with the Aperture trait mixed in, however I am unable to do that because it's private as well. Solution Make both the class and the trait public. Result You should be able to instantiate ApertureLoadBandBalancer and also create a custom load balancer with the Aperture trait mixed in.
|
LGTM, but I'm curious about what the ApertureBalancerFactory doesn't expose that you want to twiddle. |
|
In this case, just max effort. |
|
What do you mean by max effort? |
|
@roanta thoughts |
|
I think this should be configurable via the |
|
@roanta That seems correct. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
I want to use the Aperture LoadBalancerFactory with custom values.
The class is private, so we are unable to create a new object that instantiates the ApertureLoadBandBalancer class.
I also want to experiment with creating load balancers with the Aperture trait mixed in, however I am unable to do that because it's private as well.
Solution
Make both the class and the trait public.
Result
You should be able to instantiate ApertureLoadBandBalancer and also create a custom load balancer with the Aperture trait mixed in.