-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade to netty 4.1.56.Final and netty-tcnative 2.0.35.Final #884
Conversation
438528c
to
3880a28
Compare
3880a28
to
7519c0b
Compare
Codecov Report
@@ Coverage Diff @@
## develop #884 +/- ##
===========================================
- Coverage 78.33% 77.90% -0.44%
===========================================
Files 836 837 +1
Lines 24776 24968 +192
Branches 1579 1593 +14
===========================================
+ Hits 19409 19451 +42
- Misses 5367 5517 +150
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR! To add a time expectation, we'll need to run some internal tests for this upgrade and that probably won't happen until after the holidays.
This is getting hung up on some changes in TLS behavior. See here for more details. |
@peter-janssen, the patch to fix the ticket mentioned above should be in so we'll need to wait for another release before we can upgrade. Thanks for the PR, and once a release happens please feel free to submit another PR if we haven't already gotten around to it. |
Problem This is a refresh of #884: "There are new netty releases and the classifier for AArch64 was changed from linux-aarch64 to linux-aarch_64. This results in dependency problems with other projects." Solution Upgrade to netty 4.1.59.Final and netty-tcnative 2.0.35.Final for security fixes and AArch64 dependency rename. #884 was blocked because of a bug in netty 4.1.56.Final, but AFAICT this has been fixed in 4.1.59.Final. Signed-off-by: Jing Yan <jyan@twitter.com> Differential Revision: https://phabricator.twitter.biz/D629268
Problem
There are new netty releases and the classifier for AArch64 was changed from linux-aarch64 to linux-aarch_64. This results in dependency problems with other projects.
Solution
Upgrade to netty 4.1.56.Final and netty-tcnative 2.0.35.Final for security fixes and AArch64 dependency rename.
https://netty.io/news/2020/12/17/4-1-55-Final.html
https://netty.io/news/2020/12/17/4-1-56-Final.html