Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to netty 4.1.56.Final and netty-tcnative 2.0.35.Final #884

Closed
wants to merge 2 commits into from

Conversation

peter-janssen
Copy link

@peter-janssen peter-janssen commented Dec 22, 2020

Problem

There are new netty releases and the classifier for AArch64 was changed from linux-aarch64 to linux-aarch_64. This results in dependency problems with other projects.

Solution

Upgrade to netty 4.1.56.Final and netty-tcnative 2.0.35.Final for security fixes and AArch64 dependency rename.

https://netty.io/news/2020/12/17/4-1-55-Final.html
https://netty.io/news/2020/12/17/4-1-56-Final.html

@CLAassistant
Copy link

CLAassistant commented Dec 22, 2020

CLA assistant check
All committers have signed the CLA.

build.sbt Outdated Show resolved Hide resolved
@codecov-io
Copy link

codecov-io commented Dec 22, 2020

Codecov Report

Merging #884 (8067ec4) into develop (debefa8) will decrease coverage by 0.43%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #884      +/-   ##
===========================================
- Coverage    78.33%   77.90%   -0.44%     
===========================================
  Files          836      837       +1     
  Lines        24776    24968     +192     
  Branches      1579     1593      +14     
===========================================
+ Hits         19409    19451      +42     
- Misses        5367     5517     +150     
Impacted Files Coverage Δ
...er/finagle/partitioning/PartitionNodeManager.scala 53.16% <0.00%> (-30.93%) ⬇️
...ore/src/main/scala/com/twitter/finagle/Stack.scala 48.41% <0.00%> (-28.10%) ⬇️
...tter/finagle/loadbalancer/TrafficDistributor.scala 65.53% <0.00%> (-28.02%) ⬇️
...main/scala/com/twitter/finagle/stats/Metrics.scala 79.31% <0.00%> (-2.59%) ⬇️
...om/twitter/finagle/dispatch/ServerDispatcher.scala 82.97% <0.00%> (-2.13%) ⬇️
...witter/finagle/http/filter/HttpTracingFilter.scala 94.44% <0.00%> (ø)
...ain/scala/com/twitter/finagle/http/TraceInfo.scala 86.66% <0.00%> (+0.09%) ⬆️
...http/src/main/scala/com/twitter/finagle/Http.scala 84.66% <0.00%> (+0.19%) ⬆️
...ter/finagle/mux/pushsession/MuxClientSession.scala 92.92% <0.00%> (+1.01%) ⬆️
...2/transport/common/Http2StreamMessageHandler.scala 94.87% <0.00%> (+2.56%) ⬆️
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update debefa8...8067ec4. Read the comment docs.

Copy link
Contributor

@bryce-anderson bryce-anderson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! To add a time expectation, we'll need to run some internal tests for this upgrade and that probably won't happen until after the holidays.

build.sbt Outdated Show resolved Hide resolved
@bryce-anderson
Copy link
Contributor

This is getting hung up on some changes in TLS behavior. See here for more details.

@bryce-anderson
Copy link
Contributor

@peter-janssen, the patch to fix the ticket mentioned above should be in so we'll need to wait for another release before we can upgrade. Thanks for the PR, and once a release happens please feel free to submit another PR if we haven't already gotten around to it.

finaglehelper pushed a commit that referenced this pull request Mar 17, 2021
Problem
This is a refresh of #884: "There are new netty releases and the
classifier for AArch64 was changed from linux-aarch64 to
linux-aarch_64. This results in dependency problems with other
projects."

Solution
Upgrade to netty 4.1.59.Final and netty-tcnative 2.0.35.Final
for security fixes and AArch64 dependency rename.

#884 was blocked because of a bug in netty 4.1.56.Final, but
AFAICT this has been fixed in 4.1.59.Final.

Signed-off-by: Jing Yan <jyan@twitter.com>

Differential Revision: https://phabricator.twitter.biz/D629268
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants