Let people choose their test framework #59
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
So that users can select whicheve test framework or scalatest flavour they fancy.
|
Nice! This is a great idea (and patch), but since it's a breaking API change, I'll merge it for the upcoming 1.4 release. Thanks! |
|
Merged here 815b5e3 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our services use scalatest's
FunSpecor specs2, which requires us to copy-and-paste theSpecHelper.scalacode just to remove the dependency onFlatSpec.This PR avoids the problem by decoupling
SpecHelperfromFlatSpec.Given this is a breaking change on the API, I am not sure what approach to take. I've created a
FlatSpecHelperwhich should behave exactly like the oldSpecHelper, and made it part of the test source as I believe it would be nice if Finatra itself doesnt bring a transitive dependency on scalatest. I guess keepingSpecHelperand extracting the common bits in a trait with a different name would also work, happy to do that if it's better.