Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed build by reverting to 2.10.0 #77

Closed
wants to merge 1 commit into from

Conversation

pcalcado
Copy link
Contributor

@pcalcado pcalcado commented Dec 9, 2013

This is a funny one. I don't know if reverting is the best option, but the fact that the build was apparently broken for a very long time scares me. What do people run as a pre-checkin build?

Running mvn test was failing with:

*** RUN ABORTED ***
  java.lang.IncompatibleClassChangeError: class com.twitter.finatra.Examp
leSpec has interface com.twitter.finatra.test.SpecHelper as super class
  at java.lang.ClassLoader.defineClass1(Native Method)
  at java.lang.ClassLoader.defineClassCond(ClassLoader.java:637)
  at java.lang.ClassLoader.defineClass(ClassLoader.java:621)

Turns out the answer was in this warning just before the error:

[INFO] --- scala-maven-plugin:3.1.0:compile (default) @ finatra ---
[WARNING]  Expected all dependencies to require Scala version: 2.10.2
[WARNING]  com.twitter:finatra:1.4.2-SNAPSHOT requires scala version: 2.10.2
[WARNING]  com.twitter:twitter-server_2.10:1.1.0 requires scala version: 2.10.0
[WARNING] Multiple versions of scala libraries detected!

So this reverted to Scala 2.10.0 until twitter-server and others upgrade.

Running `mvn test` was failing with:
```
*** RUN ABORTED ***
  java.lang.IncompatibleClassChangeError: class com.twitter.finatra.Examp
leSpec has interface com.twitter.finatra.test.SpecHelper as super class
  at java.lang.ClassLoader.defineClass1(Native Method)
  at java.lang.ClassLoader.defineClassCond(ClassLoader.java:637)
  at java.lang.ClassLoader.defineClass(ClassLoader.java:621)
```

Turns out the answer was in this warning just before the error:
```
[INFO] --- scala-maven-plugin:3.1.0:compile (default) @ finatra ---
[WARNING]  Expected all dependencies to require Scala version: 2.10.2
[WARNING]  com.twitter:finatra:1.4.2-SNAPSHOT requires scala version: 2.10.2
[WARNING]  com.twitter:twitter-server_2.10:1.1.0 requires scala version: 2.10.0
[WARNING] Multiple versions of scala libraries detected!
```

So this reverted to Scala 2.10.0 until twitter-server and others upgrade.
@mosesn
Copy link
Contributor

mosesn commented Dec 9, 2013

@pcalcado because scala 2.10.x should be backwards compatible it shouldn't matter, right? IncompatibleClassChange seems suspect. Is it possible that you had some stale targets? Did you try a clean test?

@pcalcado
Copy link
Contributor Author

pcalcado commented Dec 9, 2013

Yes, clean test. Does master run for you?

On 9 December 2013 18:38, Moses Nakamura notifications@github.com wrote:

@pcalcado https://github.com/pcalcado because scala 2.10.x should be
backwards compatible it shouldn't matter, right? IncompatibleClassChange
seems suspect. Is it possible that you had some stale targets? Did you try
a clean test?


Reply to this email directly or view it on GitHubhttps://github.com//pull/77#issuecomment-30153466
.

@capotej
Copy link
Contributor

capotej commented Dec 9, 2013

I had this issue when merging the last release, but mvn clean package fixed it. Also, I take master very seriously and try hard not to break it: I always generate an example app and play with it before pushing to sonatype and we have travis-ci running on all commits as well: https://travis-ci.org/twitter/finatra

@capotej
Copy link
Contributor

capotej commented Dec 22, 2013

This type of error will be fixed soon when we dual publish 2.9.x and 2.10.x versions: #75

@capotej capotej closed this Dec 22, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants