-
Notifications
You must be signed in to change notification settings - Fork 244
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
scrooge-sbt-plugin: Add generated source option #187
Conversation
I am not sure if this would be better if we pulled this out the build options setting, but given that langauge is already being treated specially in the call to the compiler, this doesn't feel weird.
is the intended usage. |
617934c
to
c7871e3
Compare
Problem: scala is hardcoded into the plugin, even though sbt will happily compile java code. This is an unnecessary limitation. Solution: Add a setting key for selecting the language, and calculate the generated source extension from that.
c7871e3
to
bec8acd
Compare
Hi @benjumanji! First of all, thanks a lot for this PR! We've faced this issue recently and started working on the fix. In fact, there is already an internal PR that does the same thing but in different manner. It's also taking into account the issue with class-loaders and mustache templates (see #113 for details), which, I think, makes it a correct solution. That's said, our PR should go alive today. And, I think, we should probably merge our patch in favour of this one since it's already tested and reviewed internally. Sorry for this. And thanks again! |
No worries, all I care about is getting some sweet java code generated! Do you have any idea when this will make it into a public release? |
ping @vkostyukov Would appreciate some indication of timeline, mostly around whether I can afford to wait until this is published or if it is worth the hassle of republishing a fork internally to use until the change is public. |
Sorry @benjumanji for the delay. Our change has landed in master yesterday. Unfortunately, I don't have any estimations on when it will show up here or even be released. Maybe @nshkrob can give you some details. |
The plugin change is now pushed to develop. As for a versioned release, you should probably expect one within a month from now (we don't have a set date though). |
@nshkrob do we publish shapshots by any chance? |
No, never got around to setting it up, although it would be useful. |
Thanks! I will republish develop on our nexus (better than maintaining my own changes). |
Problem:
scala is hardcoded into the plugin, even though sbt will
happily compile java code. This is an unnecessary limitation.
Solution:
Add a setting key for selecting the language, and calculate
the generated source extension from that.