Make sure the tail in TPNamedProducer actually names a tail (#706)

* Make sure the tail in TPNamedProducer actually names a tail * add mima exclusion
twitter · Jan 13, 2017 · db801c2 · db801c2
1 parent 77b65d5
commit db801c2
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/build.sbt b/build.sbt
@@ -240,7 +240,8 @@ val ignoredABIProblems = {
     exclude[DirectMissingMethodProblem]("com.twitter.summingbird.online.executor.OperationContainer.notifyFailure"),
     exclude[ReversedMissingMethodProblem]("com.twitter.summingbird.online.executor.OperationContainer.notifyFailure"),
     exclude[IncompatibleMethTypeProblem]("com.twitter.summingbird.online.executor.AsyncBase.notifyFailure"),
-    exclude[IncompatibleMethTypeProblem]("com.twitter.summingbird.online.executor.Summer.notifyFailure")
+    exclude[IncompatibleMethTypeProblem]("com.twitter.summingbird.online.executor.Summer.notifyFailure"),
+    exclude[IncompatibleMethTypeProblem]("com.twitter.summingbird.TPNamedProducer.this")
   )
 }
 

diff --git a/summingbird-core/src/main/scala/com/twitter/summingbird/Producer.scala b/summingbird-core/src/main/scala/com/twitter/summingbird/Producer.scala
@@ -222,7 +222,7 @@ case class AlsoProducer[P <: Platform[P], +T, +R](ensure: TailProducer[P, T], re
 
 case class NamedProducer[P <: Platform[P], +T](producer: Producer[P, T], id: String) extends Producer[P, T]
 
-class TPNamedProducer[P <: Platform[P], +T](producer: Producer[P, T], id: String) extends NamedProducer[P, T](producer, id) with TailProducer[P, T]
+class TPNamedProducer[P <: Platform[P], +T](val tail: TailProducer[P, T], id: String) extends NamedProducer[P, T](tail, id) with TailProducer[P, T]
 
 /**
  * Represents filters and maps which may be optimized differently