Skip to content
This repository has been archived by the owner on Jan 20, 2022. It is now read-only.

Make sure the tail in TPNamedProducer actually names a tail #706

Merged
merged 2 commits into from
Jan 13, 2017

Conversation

johnynek
Copy link
Collaborator

@pankajroark look good?

@pankajroark
Copy link
Contributor

👍

@johnynek
Copy link
Collaborator Author

well our terrible tests strike again.

This PR passes tests locally for me, but we are see OOM it looks like. This is such a trivial change, it if compiles, it almost has to be correct. Really hard to see how it could really cost more memory.

We need to really figure something out here.

@pankajroark
Copy link
Contributor

Mima is also failing btw

@johnynek
Copy link
Collaborator Author

johnynek commented Jan 12, 2017 via email

@pankajroark
Copy link
Contributor

Yeah, the type change looks ok.

@johnynek
Copy link
Collaborator Author

our tests are so terrible.

Maybe when we upgrade storm we can finally have less flakiness.

We also need to suppress logs in the test output. Somehow the code we have for that isn't working.

@johnynek johnynek merged commit db801c2 into develop Jan 13, 2017
@johnynek johnynek deleted the oscar/fix-type-of-tpnamed branch January 13, 2017 00:22
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants