-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
command with no keys, the return value is inconsistent with redis #661
Comments
Checking for an invalid number of arguments (e.g. 0 for mget, odd for mset, etc.) is probably doable. For redis, mget is well-formed (an array
|
hello, I made a brief modification. When the number of parameters does not match, an error is returned. When a tcp connection is working normally, it will not be actively closed by the proxy, even if a command that does not conform to the rules is sent. Do you think this can be merged into the master branch? |
That seems right and I'd probably merge that if I don't find anything else during the review (and the CLA is signed) - it also needs to handle auth in the reply code.
|
This seems to be a very bad implementation. 囧 |
Describe the bug
hello,when I uses a mget with no keys ,the proxy close the conn from client to server. And the client (go-redis v8) reply a EOF is not we expected. such as get and other commands
To Reproduce
I uses a mget with no keys.
req decode is : *1\r\n#4\r\nMget\r\n
Expected behavior
return: ERR wrong number of arguments for 'mget' command
The text was updated successfully, but these errors were encountered: