Rescue from TimeoutException

[electricmonk]

I'm trying to write a method to execute a blocking method (legacy HTTP GET, for that matter) asynchronously, with retries on timeout. I'd like to avoid catching the TimeoutException, so I'm trying to use Future.rescue instead.

Follows is a specs2 test attempting to do just that; for some reason which I can't really understand, the test fails. Am I missing something, or is there a bug somewhere?

class FutureRescueTimeout extends SpecificationWithJUnit {

  import com.twitter.util._
  import java.util.concurrent.Executors

  val pool = FuturePool(Executors.newSingleThreadExecutor)
  implicit val timer = new JavaTimer
  val timeout = new RichWholeNumber(100).millis // because of implicit conversion collision between specs and twitter time

  "rescue" should {
    "recover from timeout immediately" in {
      val f: Future[Boolean] = pool {
        Thread.sleep(500)
        true
      }
      .within(timeout)
      .rescue {
        case e: TimeoutException => Future(true)
      }

      f.get must beTrue
    }

    "recover from timeout using another future" in {
      val f = recursiveRetry(List(150, 30), timeout)
      f.get must beTrue
     }

  }

  def recursiveRetry(sleep: List[Long], timeout: Duration): Future[Boolean] = pool {
      Thread.sleep(sleep.head)
      true
    }
    .within(timeout)
    .rescue {
      case e: TimeoutException if !sleep.tail.isEmpty => recursiveRetry(sleep.tail, timeout)
    }
}

[mariusae]

I just tried running this, and it works just fine.

Running com.twitter.util.FutureRescueTimeout
Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.83 sec

Results :

Tests run: 2, Failures: 0, Errors: 0, Skipped: 0

Also, the canonical way to create durations without the use of implicates is:

val timeout = Duration(100, TimeUnit.MILLISECONDS)

[mariusae]

(Can you paste the actual error you get?)

[electricmonk]

I get a TimeoutException; I use 5.3.13, BTW

rescue should
recover from timeout immediately

100.milliseconds
com.twitter.util.TimeoutException: 100.milliseconds
    at com.twitter.util.Future$$anonfun$within$1$$anonfun$2.apply$mcV$sp(Future.scala:453)
    at com.twitter.util.JavaTimer$$anon$1.run(Timer.scala:155)

recover from timeout using another future

[electricmonk]

Any clue?

[luciferous]

@electricmonk can you reproduce this with the latest release?

[vkostyukov]

Just double-checked it: not reproducible on 6.26.0. We can close it.