Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TypeError: u'_xmpp-client._tcp.jabber.org' is not a byte string #45

Closed
metajack opened this issue Oct 22, 2013 · 3 comments
Closed

TypeError: u'_xmpp-client._tcp.jabber.org' is not a byte string #45

metajack opened this issue Oct 22, 2013 · 3 comments

Comments

@metajack
Copy link
Contributor

Recent Twisted deprecated unicode string support in the DNS handling, and broke wokkel and punjab.

Adding bytes(domain) instead of domain when calling SRVConnector's constructor seems to fix this.
@metajack
Copy link
Contributor Author

Obviously this is not correct for domains with unicode.

@twonds
Copy link
Owner

twonds commented Oct 22, 2013

Maybe we should of done more than what was in this change? e57a5ad

#26

@metajack
Copy link
Contributor Author

That's probably fine. I realized after I filed this that I wasn't on the latest code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@metajack @twonds