-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Streaming id location #21
Comments
It occurred to me that it might be much safer to put the ID in the header, in case the AI API returns a UUID that may be confused with the UUID used to identify where to put the streamed in content. This wouldn't be an issue if the UUID was in the header, since the header can't be written to by any AI API. |
Switched out to using the stream-id in the header, I think it's better, but was a less direct implementation from the non-streaming implementation. |
That's great, thank you! |
Hello!
I have been trying out the streaming branch, and it's excellent so far.
One minor issue I have with it is that it puts the ID of the block that's being streamed in at the end of the source block, inside the contents.
It might be better to put it inside the SRC header line, so it's not present in the contents.
That would make it easier to copy the text while it's being streamed in, especially when using functions that copy the entire block contents, excluding the header arguments and such.
For instance, it could look something like this:
The block id would then be removed when the stream is completed, just as it is at the moment.
Perhaps there are some downsides to this. Thoughts?
The text was updated successfully, but these errors were encountered: