-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump to PHP 7 #1392
Bump to PHP 7 #1392
Conversation
Wow, thanks for putting in the effort for this! It's been my plan to do this for I am going to add this to the 1.1 milestone for now Thanks again |
It was messy with those mocks (I prefer anonymous classes or better DI), but glad you find this useful. Let me know when this is ready. I have Rector with PHPUnit and PHPStan PRs in my pocket ;) |
@tymondesigns I would really like to see |
@jerguslejko |
README.md
Outdated
<a target='_blank' rel='nofollow' href='https://app.codesponsor.io/link/5S8eNjgwCUjgucKT89buNKez/tymondesigns/jwt-auth'> | ||
<img alt='Sponsor' width='888' height='68' src='https://app.codesponsor.io/embed/5S8eNjgwCUjgucKT89buNKez/tymondesigns/jwt-auth.svg' /> | ||
</a> | ||
The MIT License (MIT) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is no need to duplicate already existing file: https://github.com/tymondesigns/jwt-auth/blob/develop/LICENSE
This can be removed
Not relevant anymore. I'm closing to clean my opened PRs. Feel free to cherry pick anything you need. |
@TomasVotruba No problem, thanks again for doing this 👍 |
Why?
Help Needed
There are 5 issues of missed mock types, that were silently passing before strict typehint.
I tried to spend dozens of minutes over that, but I don't understand their nested system.
Any help is really appreciated 👍