Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump to PHP 7 #1392

Closed
wants to merge 17 commits into from
Closed

Conversation

TomasVotruba
Copy link

@TomasVotruba TomasVotruba commented Nov 19, 2017

Why?

Help Needed

There are 5 issues of missed mock types, that were silently passing before strict typehint.
I tried to spend dozens of minutes over that, but I don't understand their nested system.

Any help is really appreciated 👍

@tymondesigns tymondesigns modified the milestone: 0.4 Nov 20, 2017
@tymondesigns
Copy link
Owner

Wow, thanks for putting in the effort for this!

It's been my plan to do this for v1.1 so this will certainly come in useful.
There are also some other changes that I will be making for that version, such as deprecating the JWTAuth class.

I am going to add this to the 1.1 milestone for now

Thanks again

@tymondesigns tymondesigns added this to the 1.1.0 milestone Nov 20, 2017
@TomasVotruba
Copy link
Author

TomasVotruba commented Nov 20, 2017

It was messy with those mocks (I prefer anonymous classes or better DI), but glad you find this useful.

Let me know when this is ready. I have Rector with PHPUnit and PHPStan PRs in my pocket ;)

@jerguslejko
Copy link

@tymondesigns I would really like to see v1.0.0 to require php7.0 as a minimal version.

@tymondesigns
Copy link
Owner

@jerguslejko v1.1.0 will be the version that implements this

README.md Outdated
<a target='_blank' rel='nofollow' href='https://app.codesponsor.io/link/5S8eNjgwCUjgucKT89buNKez/tymondesigns/jwt-auth'>
<img alt='Sponsor' width='888' height='68' src='https://app.codesponsor.io/embed/5S8eNjgwCUjgucKT89buNKez/tymondesigns/jwt-auth.svg' />
</a>
The MIT License (MIT)
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is no need to duplicate already existing file: https://github.com/tymondesigns/jwt-auth/blob/develop/LICENSE

This can be removed

@TomasVotruba
Copy link
Author

Not relevant anymore. I'm closing to clean my opened PRs.

Feel free to cherry pick anything you need.

@tymondesigns
Copy link
Owner

@TomasVotruba No problem, thanks again for doing this 👍

@TomasVotruba TomasVotruba deleted the php7-ecs branch January 29, 2018 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants