Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reveal internal but public identifiers and make them private[cats] #4618

Open
satorg opened this issue Jun 13, 2024 · 0 comments
Open

Reveal internal but public identifiers and make them private[cats] #4618

satorg opened this issue Jun 13, 2024 · 0 comments
Labels
behind-the-scenes appreciated, but not user-facing Source Breaking

Comments

@satorg
Copy link
Contributor

satorg commented Jun 13, 2024

There are several classes or other identifiers across Cats that were made public initially even though they are not supposed to be accessible outside of the library:

  • cats.kernel.instances.SeqMonoid - should only be exposed as Monoid[Seq] (see initial discussion)
  • TBD

In order to simplify the migration and alleviate toil for users, it makes sense to consider a corresponding scalafix rule for that.


The issue is created just to don't forget about it.
@satorg satorg changed the title Reveal internal but public identifier and make them private[cats] Reveal internal but public identifiers and make them private[cats] Jun 13, 2024
@satorg satorg added Source Breaking behind-the-scenes appreciated, but not user-facing labels Jun 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
behind-the-scenes appreciated, but not user-facing Source Breaking
Projects
None yet
Development

No branches or pull requests

1 participant