Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add means to test whether debug logging is enabled #2

Closed
keirlawson opened this issue Apr 25, 2018 · 2 comments
Closed

Add means to test whether debug logging is enabled #2

keirlawson opened this issue Apr 25, 2018 · 2 comments

Comments

@keirlawson
Copy link
Contributor

When attempting to port our application from Journal to log4cats 0.0.1 the first issue I encountered was there appears to be no way to test whether or not debug logging is enabled. We achieved this in Journal by using Logger.backend.isDebugEnabled.

@keirlawson keirlawson changed the title Add means to test whether debug loggin is enabled. Add means to test whether debug logging is enabled Apr 25, 2018
@ChristopherDavenport
Copy link
Member

So questioning, we want this as an attribute of the logger? I'm tempted to expose the underlying A within the algebra. However this is currently an artifactor of utilizing log4s so closely. It sounds like perhaps it would serve to build a core component with modules depending on the backends.

@keirlawson
Copy link
Contributor Author

This strikes me as a fairly generic feature common to most loggers and fairly commonly used, so my preference would be to expose it as part of the log4cats logger without requiring a reference to the underlying implementation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants