fix: mongodb connectionurl parse options

[gogotaro]

• Loop every options in mongodb connection url and turn it as object to merge with connection url object before return of method "parseMongoDBConnectionUrl"
• unit test of mongodb replicaset parse connectionurl of MongoDB replica set connection string not support with method "parseConnectionUrl" & "buildConnectionUrl" #7401
• unit test of mongodb options parse connectionurl of MongoDB options never parse in connectionUrl and after my fix was parse incorrect #7437

Description of change

src\driver\DriverUtils.ts

const optionsList = afterQuestionMark.split("&");
let optionKey: string;
let optionValue: string;

optionsList.forEach(optionItem => {
    optionKey = optionItem.split("=")[0];
    optionValue = optionItem.split("=")[1];
    optionsObject[optionKey] = optionValue;
});

Loop to create option object "optionsObject". Example, with connection string below

mongodb://testuser:testpwd@test-primary.example.com:27017/testdb?retryWrites=true&w=majority&useUnifiedTopology=true

It'll turn options to

{
    retryWrites: 'true',
    w: 'majority',
    useUnifiedTopology: 'true'
}

After that It use "optionsObject" to merge with "connectionUrl" before return as code below.

let connectionUrl: any = {
    type: type,
    host: host,
    hostReplicaSet: hostReplicaSet,
    username: decodeURIComponent(username),
    password: decodeURIComponent(password),
    port: port ? parseInt(port) : undefined,
    database: afterBase || undefined
};

for (const [key, value] of Object.entries(optionsObject)) {
    connectionUrl[key] = value
}

return connectionUrl;

Pull-Request Checklist

• Code is up-to-date with the master branch
• npm run lint passes with this change
• npm run test passes with this change
• This pull request links relevant issues as Fixes #7437
• There are new or updated unit tests validating the change
• Documentation has been updated to reflect this change
• The new commits follow conventions explained in CONTRIBUTING.md

[RA80533]

The explicit any type annotation widens the return type of parseMongoDBConnectionUrl() in a regressive manner.

Suggested change

	let connectionUrl: any = {
	let connectionUrl = {

[gogotaro]

I see, But origin of this code before my changed, It's return as any too then I try to not change It's type.

But your comment was make sense, I'll try to fixed it's type and test it to make sure that's not effect another soon.

[RA80533]

While this is written well, its intent can be made even clearer by using a simple spread operator with optionsObject like so:

let connectionUrl: any = {
    type: type,
    host: host,
    hostReplicaSet: hostReplicaSet,
    username: decodeURIComponent(username),
    password: decodeURIComponent(password),
    port: port ? parseInt(port) : undefined,
    database: afterBase || undefined,
    ...optionsObject
};

[RA80533]

If optionsObject is annotated as Record<string, string> instead of any, it can be safely merged into connectionUrl without widening the resulting type.

Suggested change

	let optionsObject: any = {};
	let optionsObject: Record<string, string> = {};

[RA80533]

Suggested change

	database: afterBase || undefined
	};
	// Loop to set every options in connectionUrl to object
	for (const [key, value] of Object.entries(optionsObject)) {
	connectionUrl[key] = value;
	}
	database: afterBase || undefined,
	...optionsObject
	};

[AlexMesser]

can you please send a clear PR without merge commits?

[gogotaro]

can you please send a clear PR without merge commits?

Sure I'll close this PR and create new pr without merge. Will inform you within 48 hours.