Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Includable in FindOptions missing {all: true} #115

Closed
MorpheusXAUT opened this issue Jul 21, 2017 · 3 comments
Closed

Includable in FindOptions missing {all: true} #115

MorpheusXAUT opened this issue Jul 21, 2017 · 3 comments
Labels

Comments

@MorpheusXAUT
Copy link
Contributor

It appears the current typings (tested at 09b3a90) are missing the include: [{all: true}] option on the Includable type in FindOptions for eager-loading all included associations (as described here).

I guess this could easily be fixed by e.g. adding all?: boolean; to the IncludeOptions interface. If that doesn't work for you due to problems with interface reuse, a new IncludeAllOptions interface would be minimal as well.

Happy to provide a PR if you want one for what could be a one-line change 😄

@felixfbecker
Copy link
Collaborator

Would accept PR but { all: true, include: ... } must not be possible

@MorpheusXAUT
Copy link
Contributor Author

MorpheusXAUT commented Jul 21, 2017

Alright, will be sending a PR with a IncludeAll interface shortly.

@MorpheusXAUT
Copy link
Contributor Author

PR sent.

On a completely unrelated note: I've also just now noticed that the QueryInterface typings are not directly exported from sequelize.d.ts. Was that on purpose/should they be accessed differently or was this an oversight?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants