Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Default conductr ip should use CONDUCTR_IP as the CLI does #44

Closed
ktoso opened this issue Mar 23, 2015 · 1 comment · Fixed by #47
Closed

Default conductr ip should use CONDUCTR_IP as the CLI does #44

ktoso opened this issue Mar 23, 2015 · 1 comment · Fixed by #47
Assignees
@ktoso
Labels
enhancement in progress

Comments

@ktoso
Copy link
Contributor

ktoso commented Mar 23, 2015

The Conduct CLI uses CONDUCTR_IP:CONDUCTR_PORT as default values instead of assuming localhost.
To be consistent among the projects the sbt plugin should do so as well.

Here's the spot: 62723f2#commitcomment-10347447
@ktoso ktoso self-assigned this Mar 23, 2015
@ktoso ktoso mentioned this issue Mar 23, 2015
Closed
ktoso added a commit to ktoso/sbt-typesafe-conductr that referenced this issue Mar 23, 2015
@ktoso
+ improves conductr url setting from the console, and smater default
93caa64 
Resolves typesafehub#44 typesafehub#46
@ktoso ktoso mentioned this issue Mar 23, 2015
Merged
ktoso added a commit to ktoso/sbt-typesafe-conductr that referenced this issue Mar 24, 2015
@ktoso
+ improves conductr url setting from the console, and smater default
aaa9835 
Resolves typesafehub#44 typesafehub#46
ktoso added a commit to ktoso/sbt-typesafe-conductr that referenced this issue Mar 24, 2015
@ktoso
+ improves conductr url setting from the console, and smater default
361d91a 
Resolves typesafehub#44 typesafehub#46
@ktoso ktoso closed this as completed in #47 Mar 24, 2015
@ktoso
Copy link
Contributor Author

ktoso commented Mar 24, 2015

resolved by #47

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ktoso ktoso

Labels
enhancement in progress
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

+ improves conductr url setting from the console, and smater default ktoso/sbt-typesafe-conductr
1 participant
@ktoso