+ improves conductr url setting from the console, and smater default #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| import akka.actor.ActorSystem | ||
| import org.scalatest.{ BeforeAndAfterAll, Matchers, PrivateMethodTester, WordSpec } | ||
|
|
||
| class SbtTypesafeConductRSpec extends WordSpec with Matchers with BeforeAndAfterAll with PrivateMethodTester { |
There was a problem hiding this comment.
Whoa - I didn't know about PrivateMethodTester. Neato.
There was a problem hiding this comment.
Quite hacky, I'd rather private[conductr], but followed style of tests around here
ktoso
force-pushed
the
wip-better-conductr-url-handling-ktoso
branch
from
93caa64
to
aaa9835
Compare
|
LGTM |
ktoso
force-pushed
the
wip-better-conductr-url-handling-ktoso
branch
from
aaa9835
to
361d91a
Compare
ktoso
added a commit
that referenced
this pull request
Mar 24, 2015
+ improves conductr url setting from the console, and smater default
This was referenced Mar 24, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #44 #46