Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to default no prefix? #4

Closed
Bartvds opened this issue Jun 26, 2014 · 2 comments
Closed

Switch to default no prefix? #4

Bartvds opened this issue Jun 26, 2014 · 2 comments

Comments

@Bartvds
Copy link
Member

Bartvds commented Jun 26, 2014

Maybe set prefix to empty string by default?

Not sure, but I think that would still be valid and sensible, as many modules use submodules that look like a path (eg: without leading dots/slash).

I originally had '__' to make the sub modules look 'private' but maybe that's not really necessary.

So this:

declare module 'foo/bar' {}

Instead of:

declare module '__foo/bar' {}

@poelstra What do you think?

@poelstra
Copy link

Haven't tested it, but it sounds like a plan yes.

@tolemac
Copy link
Contributor

tolemac commented Jan 14, 2016

What about this?

I use prefix = "" always ...

If nobody says anything I proceed to change it.

@tolemac tolemac added this to the 0.4.0 version milestone Jan 14, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants