Upgrading the stubparser #1441
Upgrading the stubparser #1441
Conversation
…vaparser-core.jar; Resolved all the compilation problems; Added a bunch of TODOs that should be resolved later regarding the switching the dependency.
…vaparser-core.jar; Resolved all the compilation problems; Added a bunch of TODOs that should be resolved later regarding the switching the dependency.
… into javaparser
- Added dependency of the framework module on javaparser-core.jar in build.xml
…er-core.jar (added parseIndexUnit method)
… into javaparser
… into javaparser
… into javaparser
…ework/lib/javaparser-core.jar
|
Looks good; I approve the pull request. |
- Removed redundant information in the manual#stub-file-format regarding the imports of enum contants.
|
I fixed it in the next commit d7c6191 |
|
No differences in Java limitations and stub parser requirements regarding the enums declarations. |
…t should be the same as in Java files.
| @@ -35,7 +35,7 @@ annoToolsDir="${cfDir}"/../annotation-tools | |||
| # Put afu jar files last, as they might contain out-of-date CF files. | |||
| # Put "checker" after the other sub-projects, as "ant bindist" puts | |||
| # other projects into the checker/build directory. | |||
| buildDirs="${cfDir}"/dataflow/build:"${cfDir}"/javacutil/build:"${cfDir}"/stubparser/build:"${cfDir}"/framework/build:"${cfDir}"/checker/build:"${annoToolsDir}"/scene-lib/bin:"${annoToolsDir}"/annotation-file-utilities/annotation-file-utilities.jar | |||
| buildDirs="${cfDir}"/dataflow/build:"${cfDir}"/javacutil/build:"${cfDir}"/framework/build:"${cfDir}"/checker/build:"${cfDir}"/checker/lib/javaparser-core.jar:"${annoToolsDir}"/scene-lib/bin:"${annoToolsDir}"/annotation-file-utilities/annotation-file-utilities.jar | |||
There was a problem hiding this comment.
Is the "${cfDir}"/checker/lib/javaparser-core.jar forgotten here from some older version of this change?
I just got a little bit confused by this addition. Not really a problem, but perhaps better clean it up.
There was a problem hiding this comment.
@panacekcz , the pull request removed the stub parser source code from the Checker Framework repository and added, in its place, a dependency on a .jar file built from an external repository. So, adding that dependence is correct.
@feliperodri , should we rename the javaparser-core.jar file to stubparser-core.jar, to emphasize that this is not the real JavaParser but our modified version of it? (However, all the package names are not changed, so it isn't currently possible to use real JavaParser at the same time as the Stub Parser.)
There was a problem hiding this comment.
@mernst , I would definitely suggest you rename the javaparser-core.jar file to stubparser-core.jar. Futures developers might find this confusing, so it is better to make clear it's a different version (even though it isn't possible to use both at the same time right now.)
There was a problem hiding this comment.
Sorry, that question should have been aimed at @Bohdankm22 . My mistake.
There was a problem hiding this comment.
@mernst In that case, I think the path should be changed to "${cfDir}"/framework/lib/javaparser-core.jar and added to javac-debug as well.
There was a problem hiding this comment.
@panacekcz, @mernst it's true, the path should be changed because the lib is in the framework/lib/. I will change it and rename to the stubparser-core.jar.
There was a problem hiding this comment.
And keep javac in sync with javac-debug, as Vlastimil pointed out. (Thanks; I missed that in my review.)
Upgrading the stubparser in the Checker Framework to use the newest JavaParser project. The stubparser will be removed and instead of this javapasrer-core.jar lib will be added in framework/lib