-
Notifications
You must be signed in to change notification settings - Fork 350
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrading the stubparser #1441
Merged
Merged
Upgrading the stubparser #1441
Changes from all commits
Commits
Show all changes
237 commits
Select commit
Hold shift + click to select a range
a20dd0f
Create test
Bohdankm22 894e8d0
Removing test
Bohdankm22 4ba561a
Merge branch 'master' of https://github.com/typetools/checker-framework
Bohdankm22 b0a2fee
Merge branch 'master' of https://github.com/typetools/checker-framework
Bohdankm22 4f9728b
Create test
Bohdankm22 0cbe3a1
Delete test
Bohdankm22 0ba23b3
Merge branch 'master' of https://github.com/Bohdankm22/checker-framework
Bohdankm22 4ef98f6
Merge branch 'master' of https://github.com/typetools/checker-framework
Bohdankm22 171aa23
Merge branch 'master' of https://github.com/typetools/checker-framework
Bohdankm22 603ab8d
Merge branch 'master' of https://github.com/typetools/checker-framework
Bohdankm22 84af457
Merge branch 'master' of https://github.com/typetools/checker-framework
Bohdankm22 d8e9622
Switched dependency of the framework module from the stubparser to ja…
Bohdankm22 b29ad22
Merge branch 'master' of https://github.com/typetools/checker-framework
Bohdankm22 7965ddb
Switched dependency of the framework module from the stubparser to ja…
Bohdankm22 3493303
Merge remote-tracking branch 'origin/javaparser' into javaparser
Bohdankm22 0756f3f
Merge branch 'master' of https://github.com/typetools/checker-framewo…
Bohdankm22 ee87522
- Added javaparser-core.jar library into the checker/lib
Bohdankm22 a47a39f
Adjusted to the changes added to the JavaParser class of the javapars…
Bohdankm22 64de4a0
- Updating javaparser-core to the changes made in there.
Bohdankm22 aa847a9
Merge branch 'master' of https://github.com/typetools/checker-framewo…
Bohdankm22 dcaeaa4
- Switching to using StubUnit from IndexUnit (changed in javaparser-c…
Bohdankm22 bfb473e
Merge branch 'master' of https://github.com/typetools/checker-framework
Bohdankm22 01b7a09
- Fixed a few TODOs with optional objects checks and raw type problems.
Bohdankm22 4e74222
- Updated javaparser-core.jar to the newest.
Bohdankm22 cef667e
Add library to classpath
mernst 0fb258e
- Updated the javaparser-core
Bohdankm22 80f47d5
Merge branch 'master' of https://github.com/typetools/checker-framewo…
Bohdankm22 fd9acc0
Merge branch 'master' of https://github.com/typetools/checker-framework
Bohdankm22 2dbb747
Merge branch 'master' of https://github.com/typetools/checker-framewo…
Bohdankm22 44788e9
Disable JDK 7 tests in this branch, because Stub Parser requires JDK 8
mernst e01094c
Merge github.com:typetools/checker-framework into javaparser
mernst fcc9c5f
Add missing element to path
mernst 241438e
Add missing library to checker.jar
mernst 6fbb923
Changed the signature of the methods that annotates the receiver in s…
Bohdankm22 0e381e6
Updated the javaparser-core.jar lib
Bohdankm22 f460ac0
Merge branch 'master' of https://github.com/typetools/checker-framewo…
Bohdankm22 5954171
Simplified test case
mernst ad8a243
Merge branch 'javaparser' of github.com:Bohdankm22/checker-framework …
mernst 9abf77b
Fix typo
mernst 06ad1d1
Simplify test case
mernst 5862975
Further simplify test case
mernst 69a39e4
Typo fixes
mernst 2cb28d7
- Fixed the comparing methods names in StubParser.java findElement me…
Bohdankm22 081a32f
- Updated the javapaser-core.jar
Bohdankm22 d48b925
- Fixed warning in parseMethod method.
Bohdankm22 940965d
- Fixed warning in parseConstructor method.
Bohdankm22 5d8baa0
- Temperary disabled giving warnings on receiver annotations for stat…
Bohdankm22 d166262
- Temperary added condition to the parseMethod and parseConstructor m…
Bohdankm22 9380249
- Renamed indeUnit to StubUnit in StubParser.java
Bohdankm22 9ebf2b1
- Updated to the newest javaparser-core.jar library.
Bohdankm22 94a3f69
- Updated javaparser-core.jar to the newest version.
Bohdankm22 c4b0a2d
Merge branch 'master' of https://github.com/typetools/checker-framewo…
Bohdankm22 04728fa
- Updated receiver annotations according to Java syntax in guieffect/…
Bohdankm22 0eee706
- Added newline at the end of the stub file guieffect/jdk.astub
Bohdankm22 34e4495
- Returning multiple package declarations to the stub file guieffect/…
Bohdankm22 a256e83
- Done on receiver annotations adjustment in the guieffect/org-eclips…
Bohdankm22 746cccb
- Fixed typo in the error message.
Bohdankm22 8c60c3e
- Fixed the issue. According to the manual "Each package declaration …
Bohdankm22 49591f0
- Updated javaparser-core.jar lib.
Bohdankm22 0957fdd
- Updated javaparser-core.jar lib.
Bohdankm22 0167d09
- Implemented visit method for ArrayType in ElementPrinter
Bohdankm22 9c20e47
Merge branch 'master' of https://github.com/typetools/checker-framewo…
Bohdankm22 9d6786c
- Updated javaparser-core.jar library.
Bohdankm22 63f2009
- Upd javaparser-core.jar lib.
Bohdankm22 b903c22
Merge branch 'master' of https://github.com/typetools/checker-framework
Bohdankm22 cf71c17
- Added temporary solution on type annotations in method/constructor …
Bohdankm22 35b4672
Merge branch 'master' of https://github.com/typetools/checker-framewo…
Bohdankm22 d232373
- Updated javapaser-core.jar lib.
Bohdankm22 7834a8c
- Updated javaparser-core.jar lib.
Bohdankm22 c775495
Merge github.com:typetools/checker-framework into javaparser
mernst edc02b4
Improve Stub Parser debugging
mernst 880b2fe
Merge github.com:typetools/checker-framework into javaparser
mernst e2369c2
Merge branch 'master' of https://github.com/typetools/checker-framewo…
Bohdankm22 0839222
- Updated javaparser-core.jar lib
Bohdankm22 82ba273
- Updated javaparser-core.jar lib with the fix of the issue with pars…
Bohdankm22 dea0637
- Temporary removed the tests in Split.java.
Bohdankm22 42250d4
- Adjusted receiver annotations to the proper syntax in regex/jdk.astub.
Bohdankm22 236d9cf
Better way to skip test (temporarily)
mernst a05f3a6
Add missing type parameter
mernst eead426
Add missing type parameter
mernst 3d20e18
Add missing import statemnts
mernst a195352
- Adjusted receiver annotations to the proper syntax in nullness-stub…
Bohdankm22 ffd1524
- Removed receiver annotations in nullness-stubfile/stubfil1.astub an…
Bohdankm22 d2dd803
- Added back receiver annotations in nullness-stubfile/stubfil1.astub…
Bohdankm22 bc08a2a
Revert "- Added back receiver annotations in nullness-stubfile/stubfi…
Bohdankm22 ff34e76
- Added skipping receiver parameter when comparing methods. A receive…
Bohdankm22 13a4625
- Removed receiver annotations in nullness-stubfile/stubfil1.astub an…
Bohdankm22 2bfc83c
- Updated javaparser-core.jar lib;
Bohdankm22 08057a4
- Adjusted visit method after added receiver annotations in MethodDec…
Bohdankm22 ec72c7c
Revert "- Added skipping receiver parameter when comparing methods. A…
Bohdankm22 611c69a
- Updated javaparser-core.jar after removing receiver from the parame…
Bohdankm22 a7d2c95
- Adjuster receiver annotations in signature/jdk.astub.
Bohdankm22 3055e6b
- Added javaparser-core lib to the classpath for -run-tests.
Bohdankm22 fe1f64a
- Added javaparser-core lib to the classpath for build-tests.
Bohdankm22 c798c76
- Added dependency on checker/lib/ to the annotationclassloader make …
Bohdankm22 44e2f8d
- Fixed dependency to the javaparser-core.jar in annotationclassloade…
Bohdankm22 864854f
- Adjusted receiver annotations in stubfile.astub.
Bohdankm22 3820854
- Added dependency on javaparser-core.jar in annotationclassloaded ma…
Bohdankm22 11c228e
- Added dependency on javaparser-core.jar in "jar" target of build.xm…
Bohdankm22 0c3ba8b
- Adjusted receiver annotations in reflection.astub.
Bohdankm22 bbff242
- Added package declarations in First.astub and NonN.astub.
Bohdankm22 b53c62c
- Added package declaration to the Class1.astub.
Bohdankm22 bf3516a
Merged with javatools master
Bohdankm22 5a6875b
- Updated the javaparser-core.jar lib.
Bohdankm22 549cf57
- Merged all classed declarations of the same package in one in the i…
Bohdankm22 f76531c
- Removed package declarations from stub files in issue824
Bohdankm22 426f1d8
- Added nullable annotation in generic argument in issue824/Second.java
Bohdankm22 2bd3d28
- Updated the javaparser-core.jar lib.
Bohdankm22 a19ff24
- Updated the javaparser-core.jar lib.
Bohdankm22 d10edd0
Merge branch 'master' of https://github.com/typetools/checker-framework
Bohdankm22 d107fac
- Updated the javaparser-core.jar lib.
Bohdankm22 1447057
- Removing package declaration as it not required.
Bohdankm22 2fc3277
- Adding back removed receiver annotation in the guieffect/jdk.astub.
Bohdankm22 ff3706e
- Reinstated the test Split in tests/index.
Bohdankm22 4d3f66d
- Reverted all the changes done in index/Split.java
Bohdankm22 a5ff1f9
- Ignored the test in Split.java
Bohdankm22 84932ce
- Added back receiver annotations in stubfile1.astub and stubfile2.astub
Bohdankm22 83ee560
Add Bohdan Sharipov to list of contributors [ci skip]
mernst 00bcb77
Merge branch 'javaparser' of github.com:Bohdankm22/checker-framework …
mernst 618ae26
Revert "- Added back receiver annotations in stubfile1.astub and stub…
Bohdankm22 0ed8ee3
- Changed comments in StubParser;
Bohdankm22 0c7eba5
- Removed modifier public from methods in enum in flow.astub.
Bohdankm22 8ee2fe3
- Commented enum declaration as the javaparser is still not able to h…
Bohdankm22 4f36800
- Added support of getting members from nested/inner classes;
Bohdankm22 0dd0065
- Fixed duplication in the map when super method is already in the child
Bohdankm22 d5bdbc6
- Replaced concatenation with append for StringBuilder.
Bohdankm22 3ea4752
Added back warning in parsing constructor after adding receiver type.
Bohdankm22 0bc585d
Fixed the problem with getting receiver annotations when parsing a co…
Bohdankm22 6faaeee
- Updated javaparser-core.jar lib.
Bohdankm22 2937f7e
- Implemented parsing nested/inner classes/interfaces after upgrading…
Bohdankm22 9fb2301
Merge github.com:typetools/checker-framework into javaparser
mernst 315f122
Fix broken merge
mernst f1d5de3
Remove unhelpful comments
mernst dcae414
Reinstate blank line
mernst a60b353
Reinstate removed command-line argument
mernst 4e52609
- Reinstate removed command-line argument;
Bohdankm22 4f92ae8
- Merged all the classes of java.awt into after one package declarati…
Bohdankm22 da55239
- Changed the order of the list of items in the framework/build.xml a…
Bohdankm22 b50a529
- Removed TODO that is no longer needed.
Bohdankm22 a863685
- Addressed changes in pull request;
Bohdankm22 526d240
- Removed debugging msgs from regular builds.
Bohdankm22 adce995
Merge branch 'master' of https://github.com/typetools/checker-framewo…
Bohdankm22 09349f6
- Updated javaparser-core.jar lib;
Bohdankm22 e7386bf
- Updated javaparser-core.jar lib.
Bohdankm22 e0b2ae2
- Updated javaparser-core.jar lib and skipped a Test1098.
Bohdankm22 880d671
- Removed expected errors as it is in typetools/checker-framework
Bohdankm22 88c64c5
- Removed commented core that is not more needed after upgrading the …
Bohdankm22 fd34e1b
- Adjusted the doc: changed the stub file format description. Import …
Bohdankm22 d866419
- Updated the javaparser-core.jar lib.
Bohdankm22 56b9706
- Updated the javaparser-core.jar lib.
Bohdankm22 a3bfee5
Merge github.com:typetools/checker-framework
mernst 9cf0bea
Merge github.com:typetools/checker-framework into javaparser
mernst 62897b7
Adapt to upstream change
mernst cc572bd
Unskip test
mernst 22f1317
- Removed added annotation.
Bohdankm22 a837a39
Small changes from code review
mernst f750746
Merge github.com:typetools/checker-framework into javaparser
mernst 4f1dc93
Changelog entry
mernst c43fdac
Merge github.com:typetools/checker-framework
mernst 52772aa
Merge github.com:typetools/checker-framework into javaparser
mernst 168a48a
- Updated the javaparser-core.jar lib;
Bohdankm22 d82555c
- Updated the javaparser-core.jar lib.
Bohdankm22 826bf6c
- Updated the javaparser-core.jar after changes in GenericAdapterVisi…
Bohdankm22 d7f9c01
- Addressed TODO left previously.
Bohdankm22 e2cb6fa
- Unignored enum in flow.astub.
Bohdankm22 48d7798
- removed replace $ from class name as javaparser supports nested/inn…
Bohdankm22 e6c7051
- added support for enum classes;
Bohdankm22 1f39dea
- fixed ClassCastException on Enum.
Bohdankm22 f09ba69
- Handling parsing classes/interfaces separately of parsing enums.
Bohdankm22 bed1599
- Removed warning on enum parsing.
Bohdankm22 d7b4a13
- Added javadoc for some methods in StubParser.
Bohdankm22 5000ebb
- Addressed TODO;
Bohdankm22 8a254a3
- Removed the check on array brackets after variable name as javapars…
Bohdankm22 9c0838c
- Implemented parseEnum method in the StubParser the same way as pars…
Bohdankm22 54524aa
Merge pull request #2 from Bohdankm22/javaparser
Bohdankm22 0a2f0fe
Merge branch 'master' of https://github.com/typetools/checker-framework
Bohdankm22 5041cdb
Remove stubparser from list of projects, since it will be removed [ci…
mernst b3322c4
- Added array annotations test.
Bohdankm22 a617728
Merge branch 'master' of https://github.com/typetools/checker-framework
Bohdankm22 19fbf8a
Merge remote-tracking branch 'origin/master'
Bohdankm22 19898ef
Merge branch 'master' of https://github.com/typetools/checker-framewo…
Bohdankm22 18c362b
- Added error expectations in multi-dimention array annot test.
Bohdankm22 a3e9654
- Fixed errors that expected in the test.
Bohdankm22 a341421
- Removed commented code.
Bohdankm22 e60188a
- Temporary disabled downstream job that should be fixed in checker-f…
Bohdankm22 4428ab7
- Fixed error msg in the test.
Bohdankm22 ce2e000
- Added more checks in test on multidimentional arrays.
Bohdankm22 e8af087
- Moved variables declaration to one place. Assignments will happen i…
Bohdankm22 38080a8
- Added documentation to the Multidimentional annotation tests.
Bohdankm22 543444e
Merge branch 'master' of https://github.com/typetools/checker-framewo…
Bohdankm22 19da5fe
Merge branch 'master' of https://github.com/typetools/checker-framework
Bohdankm22 e296908
- Added array annotations test.
Bohdankm22 67bcf1f
- Added error expectations in multi-dimention array annot test.
Bohdankm22 ddfdbcc
- Fixed errors that expected in the test.
Bohdankm22 18f372b
- Removed commented code.
Bohdankm22 03b6ac1
- Temporary disabled downstream job that should be fixed in checker-f…
Bohdankm22 e198676
- Fixed error msg in the test.
Bohdankm22 ce01cf4
- Added more checks in test on multidimentional arrays.
Bohdankm22 3398777
- Moved variables declaration to one place. Assignments will happen i…
Bohdankm22 6a363b8
- Added documentation to the Multidimentional annotation tests.
Bohdankm22 0316e0b
Merge branch 'stubtests' of https://github.com/Bohdankm22/checker-fra…
Bohdankm22 d79ee32
Merge branch 'master' of https://github.com/typetools/checker-framewo…
Bohdankm22 9d872fa
Merge branch 'master' of https://github.com/typetools/checker-framework
Bohdankm22 777a2c5
Merge branch 'master' into stubtests
Bohdankm22 c4e34f1
Merge branch 'master' of https://github.com/typetools/checker-framewo…
Bohdankm22 f1736ab
Merge branch 'master' of https://github.com/typetools/checker-framework
Bohdankm22 f90d498
Merge branch 'master' into stubtests
Bohdankm22 e2c36fd
- Improved the documentation about the stub file format in the manual.
Bohdankm22 4687d27
- Added stub parsing errors reporting if problems encountered. (#1371)
Bohdankm22 3a401e7
- Unskipped the test for the issue with annotations on varargs. (#798)
Bohdankm22 0e389d7
- Skipped the test.
Bohdankm22 aa74b5f
Avoid reassignment
mernst c9ed1dc
- Addressed requested changes in documentation and stub parse error r…
Bohdankm22 ba29b07
- Addressed requested changes in documentation and stub parse error r…
Bohdankm22 7e271f8
- Improved the report msg when the error occured while parsing a stub…
Bohdankm22 23864fa
Merge branch 'master' of https://github.com/typetools/checker-framewo…
Bohdankm22 34a4d1c
- Moving javaparser-core.jar lib from the checker to the framework mo…
Bohdankm22 af500b8
Adjust version number
mernst b036a8a
- Removing the stubparser module as now the dependency is on the fram…
Bohdankm22 be352bb
Remove unnecessary text, add placeholder for JavaParser bug report [c…
mernst e5f7ff5
Increment JDK versions
mernst 6aff749
Update travis.yml for downstream jobs
mernst d343b88
Change order of jobs [ci skip]
mernst 464cfae
Use more canonical names
mernst ce7568c
- Removing the stubparser from build.xml of the Checker Framework.
Bohdankm22 4024240
Merge branch 'remove-stub' into stubtests
Bohdankm22 f6168fe
Remove section about Stub file reader limitations
mernst 5f5ac64
Merge branch 'stubtests' of github.com:Bohdankm22/checker-framework i…
mernst 103768a
Improvements from code review
mernst 2292cdf
Merge github.com:typetools/checker-framework into stubtests
mernst 6159b1a
- Annotating constructor parameters.
Bohdankm22 d58ab59
Merge branch 'master' of https://github.com/typetools/checker-framewo…
Bohdankm22 9c62cce
- Adding test on parsing arrays and varargs parameters passed to the …
Bohdankm22 c9baa58
- Renamed parameters in test;
Bohdankm22 d7c6191
- Fixed the test varargConstructorParameterAnnotaion
Bohdankm22 ad01b2f
- Removed the entire section about declaring an enum declaration as i…
Bohdankm22 d5bb6e6
Merge branch 'master' of https://github.com/typetools/checker-framewo…
Bohdankm22 File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,9 +1,9 @@ | ||
import org.checkerframework.checker.nullness.qual.Nullable; | ||
|
||
public class First { | ||
public static <T extends @Nullable Object> void method(Supplier<T> supplier, Callable<@Nullable ? super T> callable) {} | ||
} | ||
public static <T extends @Nullable Object> void method(Supplier<T> supplier, Callable<@Nullable ? super T> callable) {} | ||
|
||
public interface First$Supplier<T extends @Nullable Object> {} | ||
public interface Supplier<T extends @Nullable Object> {} | ||
|
||
public interface First$Callable<T extends @Nullable Object> {} | ||
public interface Callable<T extends @Nullable Object> {} | ||
} |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is the
"${cfDir}"/checker/lib/javaparser-core.jar
forgotten here from some older version of this change?I just got a little bit confused by this addition. Not really a problem, but perhaps better clean it up.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@panacekcz , the pull request removed the stub parser source code from the Checker Framework repository and added, in its place, a dependency on a .jar file built from an external repository. So, adding that dependence is correct.
@feliperodri , should we rename the
javaparser-core.jar
file tostubparser-core.jar
, to emphasize that this is not the real JavaParser but our modified version of it? (However, all the package names are not changed, so it isn't currently possible to use real JavaParser at the same time as the Stub Parser.)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mernst , I would definitely suggest you rename the
javaparser-core.jar
file tostubparser-core.jar
. Futures developers might find this confusing, so it is better to make clear it's a different version (even though it isn't possible to use both at the same time right now.)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, that question should have been aimed at @Bohdankm22 . My mistake.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mernst In that case, I think the path should be changed to
"${cfDir}"/framework/lib/javaparser-core.jar
and added to javac-debug as well.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@panacekcz, @mernst it's true, the path should be changed because the lib is in the framework/lib/. I will change it and rename to the stubparser-core.jar.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And keep javac in sync with javac-debug, as Vlastimil pointed out. (Thanks; I missed that in my review.)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mernst, sure.
Doing the changes in #1451