Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Work around #1586 by disabling #1429 #1589

Merged
merged 9 commits into from
Oct 30, 2017
Merged

Work around #1586 by disabling #1429 #1589

merged 9 commits into from
Oct 30, 2017

Conversation

wmdietl
Copy link
Member

@wmdietl wmdietl commented Oct 15, 2017

This PR is for work on fixing #1586 and is not ready to merge yet.

@wmdietl
Copy link
Member Author

wmdietl commented Oct 27, 2017

Issue #293 and #341 should be re-opened until their tests are un-skipped again.

@wmdietl wmdietl changed the title Fix #1586 Work around #1586 by disabling #1429 Oct 27, 2017
@wmdietl wmdietl requested a review from smillst October 27, 2017 21:58
@wmdietl wmdietl assigned smillst and unassigned bitterfox Oct 27, 2017
Copy link
Member

@smillst smillst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good thanks!

@smillst
Copy link
Member

smillst commented Oct 27, 2017

Should we mention the reopened issues in the change log?

@smillst smillst assigned wmdietl and unassigned smillst Oct 27, 2017
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants