Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the Maven publish Gradle plugin. #4131

Merged
merged 17 commits into from
Jan 12, 2021
Merged

Conversation

smillst
Copy link
Member

@smillst smillst commented Jan 11, 2021

Fixes #3202.

Copy link
Member

@mernst mernst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, with a nice reduction of code size.

@@ -149,11 +150,11 @@ def check_all_links(afu_website, checker_website, suffix, test_mode, checker_ver
if not test_mode:
release_option = " release"
raise Exception("The link checker reported errors. Please fix them by committing changes to the mainline\n" +
"repository and pushing them to GitHub/Bitbucket, running \"python3 release_build.py all\" again\n" +
"(in order to update the development site), and running \"python3 release_push" + release_option + "\" again.")
"repository and pushing them to GitHub, running \"python release_build.py all\" again\n" +
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this should be python3 instead of python which might be Python 2 or Python 3 depending on the system.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These scripts are not yet written in python3.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The shebang line contains python3.
If that is incorrect, the shebang line should be fixed.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought these scripts needed to be converted to Python 3 and that you haven't done that yet. I see that you changed the shebang on Dec. 21 afd6923, did you also convert the scripts?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point -- just changing the shebang line is not enough. I have opened #4134.

@mernst mernst assigned smillst and unassigned mernst Jan 11, 2021
build.gradle Outdated
@@ -1044,13 +1044,6 @@ final sharedPublicationConfiguration(publication) {
organization = 'University of Washington'
organizationUrl = 'https://www.cs.washington.edu/'
}
developer {
id = 'wmdietl'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Strange correction.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You said last August that you no longer wanted to be a developer/maintainer. This reflects that and takes you off the hook for maintenance that you do not want to do.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's not how that happened, but OK.

@smillst smillst merged commit 8d9a382 into typetools:master Jan 12, 2021
@smillst smillst deleted the mavenPublish branch January 12, 2021 16:53
UtR491 pushed a commit to UtR491/checker-framework that referenced this pull request Jan 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use the "maven-publish" Gradle plugin to deploy artifacts to Maven Central
3 participants