-
Notifications
You must be signed in to change notification settings - Fork 352
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use the Maven publish Gradle plugin. #4131
Conversation
# Conflicts: # checker/build.gradle
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, with a nice reduction of code size.
@@ -149,11 +150,11 @@ def check_all_links(afu_website, checker_website, suffix, test_mode, checker_ver | |||
if not test_mode: | |||
release_option = " release" | |||
raise Exception("The link checker reported errors. Please fix them by committing changes to the mainline\n" + | |||
"repository and pushing them to GitHub/Bitbucket, running \"python3 release_build.py all\" again\n" + | |||
"(in order to update the development site), and running \"python3 release_push" + release_option + "\" again.") | |||
"repository and pushing them to GitHub, running \"python release_build.py all\" again\n" + |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this should be python3
instead of python
which might be Python 2 or Python 3 depending on the system.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These scripts are not yet written in python3.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The shebang line contains python3
.
If that is incorrect, the shebang line should be fixed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thought these scripts needed to be converted to Python 3 and that you haven't done that yet. I see that you changed the shebang on Dec. 21 afd6923, did you also convert the scripts?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point -- just changing the shebang line is not enough. I have opened #4134.
build.gradle
Outdated
@@ -1044,13 +1044,6 @@ final sharedPublicationConfiguration(publication) { | |||
organization = 'University of Washington' | |||
organizationUrl = 'https://www.cs.washington.edu/' | |||
} | |||
developer { | |||
id = 'wmdietl' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Strange correction.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You said last August that you no longer wanted to be a developer/maintainer. This reflects that and takes you off the hook for maintenance that you do not want to do.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's not how that happened, but OK.
Fixes #3202.