Merge in all index checker changes. #999
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tive variables. Closes issue 37
…r, since the value checker knows the same thing
…at requires JDK annotations
…into UpperBoundListSupport
… a constant. Fixes #14
Remove UpperBoundUtils since only one method was used in more than one class. Clean up the code that use the SameLen Checker
… that comprise the Index Checker.
…its SameLen annotation.
|
The 4 checkers are ready to be merged into master, but I'm going to do this from the command line rather than merging this pull request. So, I'm going to close this pull request. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm creating this pull request that asks for the current state of the index checker (on my fork) to be merged into a branch on typetools. The goal is to give Suzanne something to review.
This pull request includes all three Index Checker subcheckers: minlen, lowerbound, and upperbound.
Although the manual is included here, it's definitely out-of-date and needs to be updated. That's on my todo list, so it will happen eventually, but I wanted to let Suzanne start looking at some of the code instead of making her wait for me to finish things.