-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
advise '--no-verify' does not skip post-* hooks #344
advise '--no-verify' does not skip post-* hooks #344
Conversation
Hi @SKalt, Really good catch and thanks for PR 👍 After checking each Git command referenced in https://git-scm.com/docs/githooks, and except if I've missed something, it seems like only these hooks can be bypassed. https://git-scm.com/docs/git-commit#git-commit---no-verify
https://git-scm.com/docs/git-rebase#git-rebase---no-verify
https://git-scm.com/docs/git-push#git-push---no-verify
Could you modify the PR so that it displays |
Sure thing! Would you accept checking an environment variable
HUSKY_NO_VERIFY or GIT_NO_VERIFY to bypass the other hooks as a part of
this issue, or should I raise a separate issue for discussion?
…On Mon, Sep 10, 2018, 7:47 AM typicode ***@***.***> wrote:
Hi @SKalt <https://github.com/SKalt>,
Really good catch and thanks for PR 👍
After checking each Git command referenced in
https://git-scm.com/docs/githooks, and except if I've missed something,
it seems like only these hooks can be bypassed.
https://git-scm.com/docs/git-commit#git-commit---no-verify
This option bypasses the *pre-commit* and *commit-msg* hooks
https://git-scm.com/docs/git-rebase#git-rebase---no-verify
This option bypasses the *pre-rebase* hook
https://git-scm.com/docs/git-push#git-push---no-verify
Toggle the *pre-push* hook
Could you modify the PR so that it displays (add --no-verify to bypass)
only if it's one these 4 hooks?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#344 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AJ9G5cksVcQCaeisNLZQP45TDeBJciecks5uZlE4gaJpZM4WgUXc>
.
|
I'd rather separate as this one fixes an issue/bug and will be merged in any case, and the other needs consideration. |
1183178
to
3f09f1b
Compare
Fixes added and a separate issue raise in #346 . |
including the output of tslint --fix and a typo fix
3f09f1b
to
994c9f0
Compare
Changes added and #346 raised. |
Awesome, thanks! |
Closes #342.