Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

advise '--no-verify' does not skip post-* hooks #344

Merged

Conversation

SKalt
Copy link

@SKalt SKalt commented Sep 9, 2018

Closes #342.

@typicode
Copy link
Owner

Hi @SKalt,

Really good catch and thanks for PR 👍

After checking each Git command referenced in https://git-scm.com/docs/githooks, and except if I've missed something, it seems like only these hooks can be bypassed.

https://git-scm.com/docs/git-commit#git-commit---no-verify

This option bypasses the pre-commit and commit-msg hooks

https://git-scm.com/docs/git-rebase#git-rebase---no-verify

This option bypasses the pre-rebase hook

https://git-scm.com/docs/git-push#git-push---no-verify

Toggle the pre-push hook

Could you modify the PR so that it displays (add --no-verify to bypass) only if it's one these 4 hooks?

@SKalt
Copy link
Author

SKalt commented Sep 10, 2018 via email

@typicode
Copy link
Owner

I'd rather separate as this one fixes an issue/bug and will be merged in any case, and the other needs consideration.

@SKalt SKalt force-pushed the dev-improve-no-verify-message-on-post-hook branch from 1183178 to 3f09f1b Compare September 10, 2018 14:15
@SKalt
Copy link
Author

SKalt commented Sep 10, 2018

Fixes added and a separate issue raise in #346 .

including the output of tslint --fix and a typo fix
@SKalt SKalt force-pushed the dev-improve-no-verify-message-on-post-hook branch from 3f09f1b to 994c9f0 Compare September 10, 2018 14:20
@SKalt
Copy link
Author

SKalt commented Sep 10, 2018

Changes added and #346 raised.

@typicode
Copy link
Owner

Awesome, thanks!

@typicode typicode merged commit 9b1b34b into typicode:dev Sep 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants