Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tag link viewhelper creates a wrong link outside of EXT:blog plugins #5

Closed
dmitryd opened this issue Feb 6, 2019 · 1 comment
Closed
Labels
bug Something isn't working

Comments

@dmitryd
Copy link
Contributor

dmitryd commented Feb 6, 2019

Code example from a 3rd party plugin:

    <f:for each="{tags}" as="tag">
        <blog:link.tag tag="{tag}" class="blog-tag">
            {tag.title}
        </blog:link.tag>
    </f:for>

This would create a url with a wrong plugin prefix:

/de/tags/?tx_blogextender_tags%5Baction%5D=listPostsByTag&tx_blogextender_tags%5Bcontroller%5D=Post&tx_blog_tag%5Btag%5D=1&cHash=xxx

To display posts by tag correctly, it should always look like:

/de/tags/?tx_blog_tag%5Baction%5D=listPostsByTag&tx_blog_tag%5Bcontroller%5D=Post&tx_blog_tag%5Btag%5D=1&cHash=xxx

The problem is that a call UriBuilder misses $extensionName parameter.

dmitryd added a commit to dmitryd/blog that referenced this issue Feb 6, 2019
NeoBlack pushed a commit to dmitryd/blog that referenced this issue Feb 7, 2019
@benjaminkott benjaminkott added the bug Something isn't working label Feb 7, 2019
@benjaminkott
Copy link
Member

@dmitryd thx a lot - the patch is merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants