boxr:0.1.0 #679
Merged
boxr:0.1.0 #679
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
to prevent strange shapes
...instead of whatever the fuck I was doing before :P
Prevented triangle f***ery; Added `none` type for controlled f***ery;
|
Hello, and thanks for the package! Everything looks good, I just have a remark about naming conventions. The convention for Typst package is to use kebab-case names for functions and their arguments, but you seem to use snake_case. If you want to follow this convention (which is not mandatory, it is up to you to decide) can you please update your package? And if you prefer snake_case, tell me, and I'll merge this PR. |
tab|...|... -> tab(...,...); exposed get-structure-size;
|
@elegaanz Thank you! |
|
Great, thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am submitting
Description: This package allows users to easily create cardboard cutouts for various 3D structures. New structures can be defined as .json files and used immediately.
I have read and followed the submission guidelines and, in particular, I
typst.tomlfile with all required keysREADME.mdwith documentation for my packageLICENSEfile or linked one in myREADME.mdexcluded PDFs or README images, if any, but not the LICENSE