stellar-accounts-as-a-service by orsab

[orsab]

Link the bounty file

https://github.com/tyvdh/stellar-quest-bounties/blob/main/bounties/level-2/stellar-accounts-as-a-service.md

Mark your progress

• 🔵  Started working
• 🟢  Ready for review
• 🟣  Review completed

Provide relevant details

No response

[orsab]

Repo: https://github.com/orsab/stellar-bounty-l2
Demo Endpoint: https://stellar-bounty-l2.oralkin.repl.co

[LorDDark6660]

I am missing in description that i have to rename example file to .example.env

[orsab]

Hi, you have explanation into the README.md, https://github.com/orsab/stellar-bounty-l2#mv-envexample-env

…

On Sat, 29 Jan 2022, 10:02 AM LorDDarK, ***@***.***> wrote: I am missing in description that i have to rename example file to .example.env [image: IMG_20220129_085004] <https://user-images.githubusercontent.com/92062140/151652958-8857792b-d4ee-406c-898a-539358dc629a.jpg> — Reply to this email directly, view it on GitHub <#154 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AEKCP4BG6WQ33HSSZUPG2QTUYONJ7ANCNFSM5MJUZRCQ> . Triage notifications on the go with GitHub Mobile for iOS <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>. You are receiving this because you authored the thread.Message ID: ***@***.***>

[orsab]

In repl you have to click on the start button only, if you trying it locally, move .example.env into .env

…

On Sat, 29 Jan 2022, 7:25 PM Or Alkin, ***@***.***> wrote: Hi, you have explanation into the README.md, https://github.com/orsab/stellar-bounty-l2#mv-envexample-env On Sat, 29 Jan 2022, 10:02 AM LorDDarK, ***@***.***> wrote: > I am missing in description that i have to rename example file to > .example.env > > [image: IMG_20220129_085004] > <https://user-images.githubusercontent.com/92062140/151652958-8857792b-d4ee-406c-898a-539358dc629a.jpg> > > — > Reply to this email directly, view it on GitHub > <#154 (comment)>, > or unsubscribe > <https://github.com/notifications/unsubscribe-auth/AEKCP4BG6WQ33HSSZUPG2QTUYONJ7ANCNFSM5MJUZRCQ> > . > Triage notifications on the go with GitHub Mobile for iOS > <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> > or Android > <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>. > > You are receiving this because you authored the thread.Message ID: > ***@***.***> >

[DieKautz]

Nice work!

I really like the structuring of your routings and the horizon feedback when endpoints are called successfully.

When playing around with the endpoints I stumbled upon some exceptions. They are caught by the app, but the response on the api side is hard to handle (e.g. using an invalid JWT token the response will be in html).
Also maybe you should add more descriptive errors in general like:

• invalid payment amounts (negative, 0, too many decimals)
• invalid destinations (especially if they don't exist on the ledger yet (create them?)

edit: I see there is a very well made error catching in place, shouldn't the messages be displayed to the api user?

When dealing with really small and precise amounts like 0.1 and one stroop the displayed balance at /info has some floating point errors.

What do you think about crazy usernames like with unicode and stuff?

[orsab]

Hi @DieKautz, thank you for your code review. Just fixed some bugs like: error show, floating point...
I'm not antagonist, as a result, I'm not pressure users to create good usernames. Sometimes crazy username with unicode is very good practice in security 😉

[ElliotFriend]

c6dfd6696fa140475f15fc03e759408a4e0a70faf6f1184899996bc5993d8a2b