Is this a feature or a bug?

[andrestone]

When running lt conditions, electrodb builds the sk but doesn't care about adding a FilterExpression (which seems to me like the correct behavior).

  lt: {
    name: "lt",
    action(entity, state, facets = {}) {
      if (state.getError() !== null) {
        return state;
      }
      try {
        return state.setType(QueryTypes.lt).ifSK((state) => {
          const { pk, sk } = state.getCompositeAttributes();
          const { composites } = state.identifyCompositeAttributes(
            facets,
            sk,
            pk,
          );
          state.setSK(composites);
        });
      } catch (err) {
        state.setError(err);
        return state;
      }
    },
    children: ["go", "params"],
  },

When running lte conditions, it adds a FilterExpression on top of the ConditionExpression:

  lte: {
    name: "lte",
    action(entity, state, facets = {}) {
      if (state.getError() !== null) {
        return state;
      }
      try {
        return state.setType(QueryTypes.lte).ifSK((state) => {
          const { pk, sk } = state.getCompositeAttributes();
          const { composites } = state.identifyCompositeAttributes(
            facets,
            sk,
            pk,
          );
          state.setSK(composites);
          const accessPattern =
            entity.model.translations.indexes.fromIndexToAccessPattern[
              state.query.index
            ];
          if (!entity.model.indexes[accessPattern].sk.isFieldRef) {
            state.filterProperties(FilterOperationNames.lte, composites); // <---- HERE
          }
        });
      } catch (err) {
        state.setError(err);
        return state;
      }
    },
    children: ["go", "params"],
  },

The same happens with greater than conditions (differently though, it's gt that gets the FilterExpression while gte doesn't).

Is this intentional? If so what's the rationale behind this decision? Why not allow users to decide their FilterExpression using the where command?

As it stands, there's no way to build a lt or gte query with a composite SK without a FilterExpression (as far as I'm aware).

[tywalch]

Good question! Feel free to weigh in here: #228

[tywalch]

Hi @andrestone 👋

I just published version 3.0.0 which removes the character shifting and extra filters by default. Let me know if you have any questions!