Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DPlane.getQuaternion() fails with NullPointerException #74

Closed
i-make-robots opened this issue Dec 24, 2021 · 3 comments · Fixed by #78
Closed

DPlane.getQuaternion() fails with NullPointerException #74

i-make-robots opened this issue Dec 24, 2021 · 3 comments · Fixed by #78
Assignees

Comments

@i-make-robots
Copy link

i-make-robots commented Dec 24, 2021

public class ODEPhysicsTests {
	@Test
	public void planeGetQuaternionFail() {
		OdeHelper.initODE2(0);
		DSpace space = OdeHelper.createHashSpace(null);
		DPlane plane = OdeHelper.createPlane(space,0,0,1,0);
		DQuaternionC q = plane.getQuaternion();
	}
}

if getQuaternion exists for all DGeom it should succeed for all DGeom or documented that it is known to fail deliberately. Because DGeom/DPlane are interfaces what's going on behind (in DxPlane?) is invisible to me.

@tzaeschke
Copy link
Owner

Apologies for the delay.

This now throws an exception with a dedicated error message, as intended. There may already have been a message reported, but only to the active logger and with visibility "DEBUG".

@tzaeschke
Copy link
Owner

This should be fixed now in master. Fix was added with #86, test was added with #78.

@tzaeschke tzaeschke self-assigned this Apr 27, 2023
@tzaeschke
Copy link
Owner

Thanks again for reporting!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants