Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Logging problems #5

Open
OrangeDog opened this issue Jun 11, 2018 · 1 comment
Open

Logging problems #5

OrangeDog opened this issue Jun 11, 2018 · 1 comment

Comments

@OrangeDog
Copy link

Two separate issues:

  1. Code will crash if SIP.log has not been set - should default to logging.getLogger(__name__)
  2. Uses print for logging - all output should go through the log at an appropriate level
@tzeumer
Copy link
Owner

tzeumer commented Jun 11, 2018

I know the logging isn't good (it was even worse before), but I considered it as helpful enough. But as stated in the readme: "This was (nearly) my first go with Python." - so I'm well aware there is a lot room for improvement.

But I'm not anymore in Python now than I was back then. And I put this "project" on Github as a final step, but don't (in any foreseeable future) plan on putting any more work into it.

Still, I would most likely accept any pull request improving things. And everything is under MIT license, so you can do anything you like anyway. :)

Sorry, if this is a disappointing answer; but at least a reaction to the issue at all :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants