Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Should __ref_pair::__pair_type just remove_reference rather than remove_cvref? #36

Open
swolchok opened this issue Oct 7, 2022 · 0 comments
Open

Should __ref_pair::__pair_type just remove_reference rather than remove_cvref? #36

swolchok opened this issue Oct 7, 2022 · 0 comments

Comments

@swolchok
Copy link

swolchok commented Oct 7, 2022

if you have a flat_map<const K, const V>, then it seems flat_map<const K, const V>::__pair_type will be std::pair<K, V>, leaving the type with no conversion to std::pair<const K, const V> despite that being its value_type.

See https://github.com/tzlaine/flat_map/blob/master/implementation/flat_map#L50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@swolchok